Initialize Language Server on Client Connection #1535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Had to remove the failing test because it assumes that the language server is initialized on project/open command. Not proud of that, but I wasn't able to come up with the idea of how to make it work 😐 |
lolczak
approved these changes
Mar 3, 2021
Comment on lines
+15
to
+17
| resources.foldLeft(Future.successful(InitializationComponent.Initialized)) { | ||
| (action, resource) => action.flatMap(_ => resource.init()) | ||
| } |
There was a problem hiding this comment.
Future has a combinator for that Future.sequence
There was a problem hiding this comment.
Future.sequence takes Seq[Future], meaning that all futures are started at once. I need sequential behavior, when the next action starts after the previous is complete.
iamrecursion
approved these changes
Mar 4, 2021
radeusgd
requested changes
Mar 4, 2021
Closed
iamrecursion
pushed a commit
that referenced
this pull request
Mar 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
close #1403
Lazy initialization of the Language Server.
Changelog:
InitializationComponentcontaining the init logicMainModuledoes not create the directories or initializes the databases, or the truffle contextJsonConnectionControllerruns initialization logic when receiving theInitProtocolConnectionmessageImportant Notes
Checklist
Please include the following checklist in your PR: