Python interop #1541
Merged
Python interop #1541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamrecursion
approved these changes
Mar 3, 2021
| spec_impl = | ||
| Test.group "Http" <| | ||
| pending = if is_ci then Nothing else """ | ||
| The HTTP tests only run when the CI environment variable is set to true |
There was a problem hiding this comment.
Suggested change
| The HTTP tests only run when the CI environment variable is set to true | |
| The HTTP tests only run when the `CI` environment variable is set to true |
| Test.specify "should allow mutual calling of instance-level methods" <| | ||
| My_Type 3 4 . my_method_3 5 . should_equal 36 | ||
|
|
||
| Test.specify "should expose methods and fields of JS objects" <| |
There was a problem hiding this comment.
Suggested change
| Test.specify "should expose methods and fields of JS objects" <| | |
| Test.specify "should expose methods and fields of Python objects" <| |
| obj.compare 5 . should_be_false | ||
| obj.compare 11 . should_be_true | ||
|
|
||
| Test.specify "should expose array interfaces for JS arrays" <| |
There was a problem hiding this comment.
Suggested change
| Test.specify "should expose array interfaces for JS arrays" <| | |
| Test.specify "should expose array interfaces for Python arrays" <| |
Comment on lines
+76
to
+81
| Test.specify "should make Python strings type pattern-matchable" <| | ||
| str = here.make_str "x" | ||
| t = case str of | ||
| Text -> True | ||
| _ -> False | ||
| t.should_be_true |
There was a problem hiding this comment.
We should probably have a similar test for "make python numbers type pattern-matchable". Same for JS if we don't already.
| import com.oracle.truffle.api.interop.UnsupportedTypeException; | ||
| import com.oracle.truffle.api.library.CachedLibrary; | ||
|
|
||
| @NodeField(name = "foreignFunction", type = Object.class) |
There was a problem hiding this comment.
Can you implement the JsForeignNode using @NodeField? Consistency matters for this, otherwise it might be seen as intentional or important.
iamrecursion
approved these changes
Mar 4, 2021
radeusgd
reviewed
Mar 4, 2021
Comment on lines
-48
to
+49
| public static DataflowError withTrace(Object payload, Node location, StackTraceElement[] trace) { | ||
| var error = new DataflowError(payload, location); | ||
| error.setStackTrace(trace); | ||
| return error; | ||
| public static DataflowError withTrace(Object payload, AbstractTruffleException prototype) { | ||
| return new DataflowError(payload, prototype); |
There was a problem hiding this comment.
You may want to update the Javadoc comment above as the arguments have changed.
This reverts commit 946700aff4960523d5a2e7ab9cfaa50e45481229.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Adds Python interop.
Important Notes
Checklist
Please include the following checklist in your PR: