[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rank Suggestions by Self-Type Specificity #1629

Merged
merged 4 commits into from
Mar 29, 2021

Conversation

iamrecursion
Copy link
Contributor
@iamrecursion iamrecursion commented Mar 29, 2021

Pull Request Description

This PR ensures that self-type suggestions are ranked by type specificity. This means that Any methods will show up last instead of first. If, for example, a search is done on Integer, it will show methods on Integer, then methods on Number, then methods on Any.

Closes #1627.

Important Notes

This is not the most efficient implementation as I can't work out how to use the slick DSL to encode the same logic inside the database query. That is a possible enhancement for the future.

Checklist

Please include the following checklist in your PR:

  • The documentation has been updated if necessary.
  • All code conforms to the Scala, Java, and Rust style guides.
  • All documentation and configuration conforms to the markdown and YAML style guides.
  • All code has been tested where possible.

@iamrecursion iamrecursion added Type: Enhancement p-highest Should be completed ASAP labels Mar 29, 2021
@iamrecursion iamrecursion requested a review from 4e6 March 29, 2021 14:26
@iamrecursion iamrecursion self-assigned this Mar 29, 2021
Copy link
Contributor
@4e6 4e6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iamrecursion iamrecursion merged commit 8e942b5 into main Mar 29, 2021
@iamrecursion iamrecursion deleted the wip/ara/suggesions-ranking branch March 29, 2021 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p-highest Should be completed ASAP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Suggestions Ordering
2 participants