[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Some Implementations of Vector Constructors #1650

Merged
merged 3 commits into from
Apr 6, 2021
Merged

Fix Some Implementations of Vector Constructors #1650

merged 3 commits into from
Apr 6, 2021

Conversation

iamrecursion
Copy link
Contributor
@iamrecursion iamrecursion commented Apr 6, 2021 •
edited
Loading

Pull Request Description

What it says on the tin. These were found as part of investigating a strange bug that turned out to be in GraalJS. GraalJS has fixed the issue in 21.1.0.

Important Notes

API changes:

  • rename: Vector.from_polyglot_array -> Vector.from_array

Checklist

Please include the following checklist in your PR:

  • The documentation has been updated if necessary.
  • All code conforms to the Scala, Java, and Rust style guides.
  • All documentation and configuration conforms to the markdown and YAML style guides.
  • All code has been tested where possible.

@iamrecursion iamrecursion added Type: Enhancement --breaking Important: a change that will break a public API or user-facing behaviour p-highest Should be completed ASAP labels Apr 6, 2021
@iamrecursion iamrecursion requested a review from 4e6 April 6, 2021 15:33
@iamrecursion iamrecursion self-assigned this Apr 6, 2021
@iamrecursion iamrecursion merged commit 8b05889 into main Apr 6, 2021
@iamrecursion iamrecursion deleted the wip/ara/js-debug branch April 6, 2021 19:06
iamrecursion added a commit that referenced this pull request Apr 7, 2021
@iamrecursion
Fix some implementations for the Vector constructors (#1650)
64d9960
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@4e6 4e6 4e6 approved these changes

@kustosz kustosz Awaiting requested review from kustosz

@radeusgd radeusgd Awaiting requested review from radeusgd

@wdanilo wdanilo Awaiting requested review from wdanilo

Assignees

@iamrecursion iamrecursion

Labels
--breaking Important: a change that will break a public API or user-facing behaviour p-highest Should be completed ASAP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iamrecursion @4e6