[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install Required GraalVM Components #1651

Merged
merged 9 commits into from
Apr 7, 2021
Merged

Install Required GraalVM Components #1651

merged 9 commits into from
Apr 7, 2021

Conversation

4e6
Copy link
Contributor
@4e6 4e6 commented Apr 6, 2021

Pull Request Description

close #1645

The project manager ensures that the required GraalVM components are installed. The logic is triggered in two cases: after the new GraalVM installation, and during the lookup of the existing runtime to make sure that the previously installed version has all required features.

Important Notes

Checklist

Please include the following checklist in your PR:

  • The documentation has been updated if necessary.
  • All code conforms to the Scala, Java, and Rust style guides.
  • All documentation and configuration conforms to the markdown and YAML style guides.
  • All code has been tested where possible.

@4e6 4e6 added Type: Enhancement p-high Should be completed in the next sprint labels Apr 6, 2021
@4e6 4e6 self-assigned this Apr 6, 2021

object GraalVMComponent {

val js: GraalVMComponent = GraalVMComponent("js")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JS is installed by default.

Copy link
Member
@radeusgd radeusgd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really great.

Just one minor comment (the javaHome logic seems redundant) and one slightly more important one - the installation logic should handle failure more carefully.

@4e6 4e6 merged commit ec66117 into main Apr 7, 2021
@4e6 4e6 deleted the wip/db/graal-migration branch April 7, 2021 15:19
iamrecursion pushed a commit that referenced this pull request Apr 7, 2021
Project manager ensures that the required 
GraalVM components are installed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p-high Should be completed in the next sprint
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Project Manager Should Prioritize Bundled Runtime
3 participants