-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install Required GraalVM Components #1651
Conversation
|
||
object GraalVMComponent { | ||
|
||
val js: GraalVMComponent = GraalVMComponent("js") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
JS is installed by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really great.
Just one minor comment (the javaHome
logic seems redundant) and one slightly more important one - the installation logic should handle failure more carefully.
...nager/src/main/scala/org/enso/runtimeversionmanager/components/GraalVMComponentUpdater.scala
Outdated
Show resolved
Hide resolved
...manager/src/main/scala/org/enso/runtimeversionmanager/components/RuntimeVersionManager.scala
Show resolved
Hide resolved
Project manager ensures that the required GraalVM components are installed.
Pull Request Description
close #1645
The project manager ensures that the required GraalVM components are installed. The logic is triggered in two cases: after the new GraalVM installation, and during the lookup of the existing runtime to make sure that the previously installed version has all required features.
Important Notes
Checklist
Please include the following checklist in your PR: