[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve Clashing Project Ids #1665

Merged
merged 7 commits into from
Apr 13, 2021
Merged

Resolve Clashing Project Ids #1665

merged 7 commits into from
Apr 13, 2021

Conversation

4e6
Copy link
Contributor
@4e6 4e6 commented Apr 13, 2021 •
edited
Loading

Pull Request Description

close #1581

Project manager assigns fresh identifiers to the projects that have duplicate project ids. Which project is original is decided by the directory creation time.

Changelog

  • feat: when reading the projects list, resolve duplicate project ids based on the directory creation time
  • test: set SQLite journaling mode to memory, to avoid messing up the test environment

Important Notes

Checklist

Please include the following checklist in your PR:

  • The documentation has been updated if necessary.
  • All code conforms to the Scala, Java, and Rust style guides.
  • All documentation and configuration conforms to the markdown and YAML style guides.
  • All code has been tested where possible.

@4e6 4e6 added Type: Enhancement p-high Should be completed in the next sprint labels Apr 13, 2021
@4e6 4e6 self-assigned this Apr 13, 2021
@4e6 4e6 requested a review from iamrecursion as a code owner April 13, 2021 09:23
@iamrecursion iamrecursion merged commit fde4f2d into main Apr 13, 2021
@iamrecursion iamrecursion deleted the wip/db/project-id-clash branch April 13, 2021 12:19
iamrecursion pushed a commit that referenced this pull request Apr 28, 2021
@4e6 @iamrecursion
Resolve clashing project identifiers (#1665)
8800c27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamrecursion iamrecursion iamrecursion approved these changes

@kustosz kustosz Awaiting requested review from kustosz

@radeusgd radeusgd Awaiting requested review from radeusgd

Assignees

@4e6 4e6

Labels
p-high Should be completed in the next sprint
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handling Project ID Collisions
2 participants
@4e6 @iamrecursion