(cherry-pick) Hermes visionOS CI scripts #45124
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: As discussed with cipolleschi offline, this PR adds visionOS to the prebuilt Hermes binary for the CI. [IOS] [ADDED] - Prebuilt version of Hermes for visionOS Pull Request resolved: facebook#44691 Test Plan: Check if CI builds xcframework for visionOS. Reviewed By: cortinico Differential Revision: D58189271 Pulled By: cipolleschi fbshipit-source-id: dc76746b2c1e22670bef4c21411a598e43dad577
Summary: Pull Request resolved: facebook#44854 In the previous change, I followed the suggestion of the linter but in that case I shouldn't. This was breaking circleci and GHA This change will fix it ## Changelog: [Internal] - Fix OSS CI Reviewed By: huntie Differential Revision: D58358164 fbshipit-source-id: eba1f41c17a191aa9d3bd213fddddd8ff3c24a6a
Summary: Pull Request resolved: facebook#44855 We recently landed a change that added support for VisionOS in the general test case for GHA but we forgot to include nightlies. This change takes the same changes applied to [this file](https://github.com/facebook/react-native/pull/44691/files#diff-12d2c3c126fcc84106dce4b6d2be2220f018661b111a5382ad6effc1047f66aeR114-R368) and applies them to the nightlies. [Internal] - Add GHA nightlies support for VisionOS Reviewed By: huntie Differential Revision: D58358115 fbshipit-source-id: 577f62e53fb530bc534ba98508801a6970aef095
|
Hey @cipolleschi As far as I understand we need this cherry-picked so the Release Crew can include visionOS hermes slice in the next 0.74.x release, right? Looks like it's failing due to lots of changes in the CI, do you know what else should I cherry-pick for this to build properly? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR is a cherry-pick of 3 commits:
These commits are required to build visionOS Hermes slice on the CI for the pre-built to work correctly.
Changelog:
[IOS] [ADDED] - Add visionOS slice to Hermes prebuilt
Test Plan:
CI Green