fix: ensure --build-output destination exists
#45182
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @tido64 just FYI |
5969f7f
to
28357a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Replicates react-native-community/cli@48d4c29, which landed inside
cli-plugin-metroinside RNC CLI, but because of migration of code tocommunity-cli-pluginit looks like apparently the fix wasn't replicated.Changelog:
[GENERAL] [FIXED] - Ensure
--build-outputdestination existsTest Plan:
Specify a new directory that doesn't exists inside
--build-output:npx react-native bundle --build-output dist/new-dir/index.bundleand this command shouldn't fail.