Use RAII for cleaning up global_refs in JavaTurboModule #45218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Differential Revision: D59107106
|
This pull request was exported from Phabricator. Differential Revision: D59156494 |
Differential Revision: D59107105
Summary: Pull Request resolved: facebook#45218 Noticed that when an exception occurred we would not cleanup global_refs, leaking them in the global table. Restructure this to use RAII and rely on JNIArgs to do the cleanup as necessary. Changelog: [Android][Internal] Differential Revision: D59156494
|
This pull request was exported from Phabricator. Differential Revision: D59156494 |
7a3b921
to
d91b8f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Noticed that when an exception occurred we would not cleanup global_refs, leaking them in the global table.
Restructure this to use RAII and rely on JNIArgs to do the cleanup as necessary.
Changelog: [Android][Internal]
Differential Revision: D59156494