[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for user refresh tokens to authenticate supply #16352

Closed
moly opened this issue Apr 21, 2020 · 2 comments
Closed

Add support for user refresh tokens to authenticate supply #16352

moly opened this issue Apr 21, 2020 · 2 comments

Comments

@moly
Copy link
moly commented Apr 21, 2020

Feature Request

Add support for user refresh tokens to authenticate supply. User refresh tokens are described here: https://developers.google.com/android-publisher/authorization

Motivation Behind Feature

In some corporate setups the play store page is not owned/managed internally and it is therefore difficult/impossible to get access to the service account. Adding support for alternative authentication methods would make fastlane more useful in these situations.

Feature Description

It would be useful if supply was able to accept a json file containing refresh token details and use this to authenticate with the google api. The code change required would be very small, this would need to be added to initialize in AbstractGoogleServiceClient:

if is_refresh_token
    auth_client = Google::Auth::UserRefreshCredentials.make_creds(json_key_io: service_account_json, scope: self.class::SCOPE)
else
    auth_client = Google::Auth::ServiceAccountCredentials.make_creds(json_key_io: service_account_json, scope: self.class::SCOPE)
end

is_refresh_token could be set by a command line switch, or determined automatically by inspecting the provided json.

Alternatives or Workarounds

None that I know of.

@fastlane-bot
Copy link

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates.

Please make sure to update to the latest fastlane version and check if that solves the issue. Let us know if that works for you by adding a comment 👍

Friendly reminder: contributions are always welcome! Check out CONTRIBUTING.md for more information on how to help with fastlane and feel free to tackle this issue yourself 💪

@fastlane-bot
Copy link

This issue will be auto-closed because there hasn't been any activity for a few months. Feel free to open a new one if you still experience this problem 👍

@fastlane fastlane locked and limited conversation to collaborators Jul 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants