[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[supply] added support for refresh tokens as an authentication method #16414

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

[supply] added support for refresh tokens as an authentication method #16414

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
4262381
[supply] added support for refresh tokens as an authentication method…
moly May 1, 2020
2e60af8
[supply] fixed rubocop error
moly May 1, 2020
1c9fa04
renamed json_token to refresh_token in supply
moly May 12, 2020
2b254f3
fixed exception when using json_key with supply
moly May 12, 2020
26ba39d
removed empty line at method body end
moly May 12, 2020
f810006
fixed exception when Client is created without any supply parameters
moly May 13, 2020
3277fbf
refactored refresh_token supply code to fix failing tests
moly May 13, 2020
4167a1f
fixed error message not showing when no authentication parameters pro…
moly May 14, 2020
28d82aa
Merge branch 'master' into json_token
janpio May 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixed error message not showing when no authentication parameters pro… 
…vided
  • Loading branch information
@moly
moly committed May 14, 2020
commit 4167a1f5142a8772744cadff2b6fc7ace356de0d
4 changes: 2 additions & 2 deletions supply/lib/supply/client.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,8 @@ def self.make_from_config(params: nil)
elsif params[:refresh_token] || params[:refresh_token_data]
refresh_token_data = self.refresh_token_authentication(params: params)
return self.new(refresh_token_json: refresh_token_data, params: params)
else
UI.user_error!("No authentication parameters were specified. These must be provided in order to authenticate with Google")
end
end

Expand All @@ -150,8 +152,6 @@ def self.service_account_authentication(params: nil)
}
service_account_json = StringIO.new(JSON.dump(cred_json))
service_account_json
else
UI.user_error!("No authentication parameters were specified. These must be provided in order to authenticate with Google")
end
end

Expand Down