[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[action][set_github_release] Support generate_release_notes parameter #19558

Merged
merged 1 commit into from
Nov 15, 2021
Merged

[action][set_github_release] Support generate_release_notes parameter #19558

merged 1 commit into from
Nov 15, 2021

Conversation

yutailang0119
Copy link
Contributor
@yutailang0119 yutailang0119 commented Nov 1, 2021

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

Description

Testing Steps

desc "Create Release to GitHub"
lane :create_github_release do |options|
  tag_name = options.fetch(:tag_name)
  github_release = set_github_release(
    repository_name: ENV["GITHUB_REPO"],
    api_token: ENV["GITHUB_REPO"],
    name: tag_name,
    tag_name: tag_name,
    description: "Release by fastalane\n=====",
    is_generate_release_notes: true
  )
end

@google-cla google-cla bot added the cla: yes label Nov 1, 2021
@yutailang0119 yutailang0119 changed the title [action][set_github_release] Support generate_release_notes parameter on set_github_release [action][set_github_release] Support generate_release_notes parameter Nov 2, 2021
Copy link
Member
@joshdholtz joshdholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is so cool! I had no idea this was a thing 😱 Thank you for this contribution ❤️

@joshdholtz joshdholtz merged commit 1879cc2 into fastlane:master Nov 15, 2021
@yutailang0119 yutailang0119 deleted the set_github_release-generate-release-notes branch November 16, 2021 04:46
@fastlane-bot
Copy link

Congratulations! 🎉 This was released as part of fastlane 2.198.0 🚀

@fastlane fastlane locked and limited conversation to collaborators Jan 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants