[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[action][get_version_number] - search for MARKETING_VERSION in build settings if target has no INFO_PLIST #19589

Merged
merged 2 commits into from
Nov 15, 2021

Conversation

nekrich
Copy link
Contributor
@nekrich nekrich commented Nov 9, 2021

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

I have a project with static lib target, and it has no INFO_PLIST in build settings. And get_version_number fails to get MARKETING_VERSION from build settings

Description

Despite missing INFO_PLISToption, there still is a MARKETING_VERSION 😅.
So I added an option to skip looking for the value, or used variable in the Info.plist file if there is none. As the default value for looking in the build settings, I use MARKETING_VERSION, which is default from Xcode 11.

Testing Steps

I've updated specs for get_version_number to cover this case.

Manual steps:

  1. Create target w/o INFO_PLIST build setting (static lib, aggregate).
  2. Set MARKETING_VERSION build setting.
  3. Run get_version_number on that target.

@google-cla google-cla bot added the cla: yes label Nov 9, 2021
@nekrich nekrich changed the title get_version_number - search for MARKETING_VERSION in build settings if target has no INFO_PLIST [action][get_version_number] - search for MARKETING_VERSION in build settings if target has no INFO_PLIST Nov 9, 2021
Copy link
Member
@joshdholtz joshdholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thank you so much for making this change 🙌

@joshdholtz joshdholtz merged commit 54d0fcd into fastlane:master Nov 15, 2021
@fastlane-bot
Copy link

Congratulations! 🎉 This was released as part of fastlane 2.198.0 🚀

@nekrich nekrich deleted the fix-get_version_number branch December 13, 2021 17:25
@fastlane fastlane locked and limited conversation to collaborators Feb 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants