[action][get_version_number] - search for MARKETING_VERSION in build settings if target has no INFO_PLIST #19589
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
bundle exec rspec
from the root directory to see all new and existing tests passbundle exec rubocop -a
to ensure the code style is validMotivation and Context
I have a project with static lib target, and it has no INFO_PLIST in build settings. And get_version_number fails to get MARKETING_VERSION from build settings
Description
Despite missing INFO_PLISToption, there still is a MARKETING_VERSION 😅.
So I added an option to skip looking for the value, or used variable in the Info.plist file if there is none. As the default value for looking in the build settings, I use MARKETING_VERSION, which is default from Xcode 11.
Testing Steps
I've updated specs for get_version_number to cover this case.
Manual steps: