[gym] Add xcodebuild_command option #19614
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
bundle exec rspec
from the root directory to see all new and existing tests passbundle exec rubocop -a
to ensure the code style is validMotivation and Context
We have not the best CI runner in the world (Azure Pipelines), and we trying to move to self-hosted runners with M1 CPUs. Unfortunately, Azure Pipelines agent runs everything under Rozetta (microsoft/azure-pipelines-agent#3184), and we want to put
arch -arm64
beforexcodebuild
while archiving our targets.Additionally, we used the
xcodebuild_command
option inscan
, and were surprised thatgym
still misses it despite the fact scan usesGYM_XCODE_BUILD_COMMAND
ENV var for this option. If you need me to change the ENV var name inscan
ping me, and I'll do it.Description
Copy-pasted everything related to
xcodebuild_command
fromscan
馃槄 and covered it with a test.Also, I removed
env NSUnbufferedIO=YES
prefix for the defaultxcodebuild_command
value in thegym
action, cause so far it worked well without it.Testing Steps