[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gym] Add xcodebuild_command option #19614

Merged

Conversation

nekrich
Copy link
Contributor
@nekrich nekrich commented Nov 16, 2021

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

We have not the best CI runner in the world (Azure Pipelines), and we trying to move to self-hosted runners with M1 CPUs. Unfortunately, Azure Pipelines agent runs everything under Rozetta (microsoft/azure-pipelines-agent#3184), and we want to put arch -arm64 before xcodebuild while archiving our targets.

Additionally, we used the xcodebuild_command option in scan, and were surprised that gym still misses it despite the fact scan uses GYM_XCODE_BUILD_COMMAND ENV var for this option. If you need me to change the ENV var name in scan ping me, and I'll do it.

Description

Copy-pasted everything related to xcodebuild_command from scan 馃槄 and covered it with a test.

Also, I removed env NSUnbufferedIO=YES prefix for the default xcodebuild_command value in the gym action, cause so far it worked well without it.

Testing Steps

scan(xcodebuild_command: `echo 'Hello, World!'; xcodebuild`)

@google-cla google-cla bot added the cla: yes label Nov 16, 2021
Copy link
Member
@joshdholtz joshdholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OMG, I did not remember that scan had this and also that it was prefixed with GYM 馃槵 That feels like a bad copy paste bug we will just leave that there. This looks great though! Thanks for adding this 鉂わ笍

@joshdholtz joshdholtz merged commit 5cf3bd8 into fastlane:master Nov 17, 2021
Copy link
@fastlane-bot fastlane-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations! 馃帀 This was released as part of fastlane 2.198.1 馃殌

@nekrich nekrich deleted the gym-add-xcodebuild_command-option branch December 13, 2021 17:25
@fastlane fastlane locked and limited conversation to collaborators Feb 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants