[match] Add an option to safe remove certs for nuke #19617
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
bundle exec rspec
from the root directory to see all new and existing tests passbundle exec rubocop -a
to ensure the code style is validMotivation and Context
There is no possibility to remove certificates with
match nuke
from certs repository without revoking them on the Developer Portal.Such a change allows for removing certificate from repository and leaving it on the Developer Portal and creating a new certificate with
match
. It could be beneficial for Enterprise accounts (as revoking enterprise certificate breaks apps for users).Description
In this PR
safe_remove_certs
optional parameter is added tomatch
. By default it'sfalse
. When it'strue
, certs should be removed from certs repository but shouldn't be revoked on the Developer Portal.Example of execution:
Logging to console is adjusted when
safe_remove_certs
is used.So far tested by analysing logs after commenting out code responsible for revoking certs, deleting profiles and committing changes to match repository in
nuke_it_now
and code responsible for deleting files from repository and uninstalling profiles from local machine indelete_files!
Testing Steps
Update
Gemfile
and runbundle install