[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[match] Add an option to safe remove certs for nuke #19617

Merged

Conversation

lucgrabowski
Copy link
Contributor
@lucgrabowski lucgrabowski commented Nov 16, 2021

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

There is no possibility to remove certificates with match nuke from certs repository without revoking them on the Developer Portal.
Such a change allows for removing certificate from repository and leaving it on the Developer Portal and creating a new certificate with match. It could be beneficial for Enterprise accounts (as revoking enterprise certificate breaks apps for users).

Description

In this PR safe_remove_certs optional parameter is added to match. By default it's false. When it's true, certs should be removed from certs repository but shouldn't be revoked on the Developer Portal.
Example of execution:

bundle exec fastlane match nuke distribution --safe_remove_certs
bundle exec fastlane match nuke enterprise --safe_remove_certs

Logging to console is adjusted when safe_remove_certs is used.

So far tested by analysing logs after commenting out code responsible for revoking certs, deleting profiles and committing changes to match repository in nuke_it_now and code responsible for deleting files from repository and uninstalling profiles from local machine in delete_files!

without safe_remove_certs

with safe_remove_certs

Testing Steps

Update Gemfile and run bundle install

gem "fastlane", :git => "https://github.com/lucgrabowski/fastlane.git", :branch => "lucgrabowski-safe-remove-certs"

@google-cla google-cla bot added the cla: yes label Nov 16, 2021
@lucgrabowski lucgrabowski marked this pull request as ready for review December 23, 2021 12:32
@Kukurijek
Copy link
Contributor

Such a great feature! 🚀

Copy link
Member
@joshdholtz joshdholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is super awesome! Thank you for making this 😊 I'll get this released tonight 💪

@fastlane-bot
Copy link

Congratulations! 🎉 This was released as part of fastlane 2.204.0 🚀

@fastlane fastlane locked and limited conversation to collaborators Apr 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants