[action] Adding no overwrite and local only options to the pod repo push command #20455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey |
getaaron
approved these changes
Jul 28, 2022
|
Looks great, thanks for the PR! |
|
Hey @polmum 👋 Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉 Please let us know if this change requires an immediate release by adding a comment here 👍 |
There was a problem hiding this comment.
Congratulations! 🎉 This was released as part of fastlane 2.209.0 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
bundle exec rspecfrom the root directory to see all new and existing tests passbundle exec rubocop -ato ensure the code style is validMotivation and Context
The PR adds new parameters to the Cocoapods command
pod repo pushthat were missing from the Fastlane action but were present on the Cocoapods command.Description
Two new options are being added to the
pod repo pushcommand:no_overwrite, which disallows pushing a spec that would overwrite an existing one
local_only, which skips the step of pushing to its remote, basically acting like a dry run.
Testing Steps
I've follow the rules found on https://github.com/fastlane/fastlane/blob/master/Testing.md. I've also tested the command locally, and found no issues.