-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] import from gem action #20294
Open
lacostej
wants to merge
9
commits into
fastlane:master
Choose a base branch
from
lacostej:feature/import_from_gem_action
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4dae79c
to
2b840b7
Compare
4 tasks
2b840b7
to
17e3e27
Compare
17e3e27
to
a02c17b
Compare
…_plugins/dependency_with_plugins.gemspec Co-authored-by: Roger Oba <rogerluan.oba@gmail.com>
a02c17b
to
d6c5146
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
bundle exec rspec
from the root directory to see all new and existing tests passbundle exec rubocop -a
to ensure the code style is validMotivation and Context
This builds on top of #20293
We wish to replace
import_from_git
with this new action to use gem files to package the shared Fastfile and its dependencies. Together with the transitive dependencies it simplifies the use of a shared Fastfile.We modify our repository containing our shared Gemfile by
fastlane_version "x.y.z"
in the shared Fastfile with a proper version constraint in the gemspec. For consumer projects, bundler will resolve the right dependency when neededFor our consumer projects this gives the following results:
to
Extra benefits: builds are now reproducible. Updating the shared fastfile requires doing an update in the corresponding user projects.
I am opening this for discussion and can clean the code, add tests as needed.
Who can provide some feedback on this? @joshdholtz maybe?
Description
Testing Steps