-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[spaceship] add visionOS support for Connect API #21929
base: master
Are you sure you want to change the base?
Conversation
Hello all, do you have any idea when this commit could be merged ? Once it will be done I should be able upload to test flight as with ios and mac through ' upload_to_testflight ', right ? |
@radim93 yes, upload_to_testflight works. As I'm no maintainer of fastlane, I unfortunately can't tell when this will be merged. |
@rogerluan would be great if this could be merged! 🙏 This further completes visionOS support that was started in #21574. I’ve tested this branch by using deliver to upload our visionOS app to App Store Connect and it works great. I would vote for merging this PR in favor of #21864, which only implements a subset of the changes. |
@@ -99,7 +99,7 @@ def self.available_options | |||
optional: true, | |||
default_value: "ios", | |||
verify_block: proc do |value| | |||
UI.user_error!("The platform can only be ios, appletvos, or osx") unless %('ios', 'appletvos', 'osx').include?(value) | |||
UI.user_error!("The platform can only be ios, appletvos, xros or osx") unless %('ios', 'appletvos', 'xros', 'osx').include?(value) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the supported platform name here be xros
or visionos
?
I’m thinking it should be the latter, as xrOS is just a leftover from the beta period before Apple decided on / communicated the visionOS name, so it’s effectively superseded by visionOS
(even though it’s of course still used internally by Xcode SDKs).
It would definitely feel more natural to me to write platform :visionos do ...
than to use :xros
, but so this is not a question specific to Deliver but a general Fastlane question.
Would love to see this merged and released! |
I’ve opened a new PR #22032 with the rebased commit so we can get this integrated – hope that’s ok! 🙏 |
Checklist
bundle exec rspec
from the root directory to see all new and existing tests passbundle exec rubocop -a
to ensure the code style is validci/circleci
builds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)Motivation and Context
While #21574 already introduced basic support for visionOS, we noticed that running
pilot
currently fails with the following output:Description
While investigating the issue, we noticed that the platforms that are supported by the Connect API have not been updated back then. This PR adds
VISION_OS
as a supported platform, as documented by the Apple documentation.Adding
VISION_OS
to this list fixes the issue mentioned above.I could not find any tests yet that validate the
map
function ofSpaceship::ConnectAPI::Platform
. If you'd like me to add tests for that, please give me a hint whether there is already something that should be extended.Testing Steps
Create a visionOS application and try to upload it to the App Store, e.g. with
pilot
.