[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate Credential Account #22122

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

danielhalim92
Copy link
@danielhalim92 danielhalim92 commented Jul 3, 2024

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I see several green ci/circleci builds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.
  • I've added or updated relevant unit tests.

Motivation and Context

We use supply method to upload our app bundle (Android) to Play Store. Recently we are migrating our service account key usage to Workload Identity Federation (WIF) in order to enhance the security.

Description

Added validation to check whether it's an external_account or service_account to fix error missing client_email caused by https://github.com/googleapis/google-auth-library-ruby/blob/main/lib/googleauth/json_key_reader.rb#L24 when using Workload Identity Federation

  • service_account –> Google::Auth::ServiceAccountCredentials
  • external_account –> Google::Auth::ExternalAccount::Credentials

Testing Steps

Successfully validate the credential using the credential config from WIF

@github-actions github-actions bot added the tool: supply upload_to_playstore label Jul 3, 2024
@danielhalim92
Copy link
Author

maybe @joshdholtz can help to review this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tool: supply upload_to_playstore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant