[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add non random mode #14

Merged

Conversation

PupoSDC
Copy link
Contributor
@PupoSDC PupoSDC commented Oct 22, 2020

Fixes 13

Adds the ability to have a reproducible mode for lorem-ipsums. This is somewhat important to me since I'm using this awesome library in a project that now is undergoing snapshot testing. Let me know if I can do anything else to get this merged :)

@PupoSDC PupoSDC changed the title #13 Add non random mode Add non random mode Oct 23, 2020
@fatihtelis fatihtelis merged commit aa69b12 into fatihtelis:master Dec 1, 2020
@fatihtelis
Copy link
Owner
fatihtelis commented Dec 1, 2020

Thanks for contributing @PupoSDC. Sorry for the late answer. It will be a nice feature for people who need static "Lorem Ipsum" text. I've merged your PR and made a small tweak before releasing the new version. You can use "random" prop on react-lorem-ipsum@1.4.8. I've also added the new prop on demo page. Thanks again. :)

@fatihtelis fatihtelis added the enhancement New feature or request label Dec 1, 2020
@PupoSDC PupoSDC deleted the 13-add-flag-for-freezing-content branch December 1, 2020 14:05
@PupoSDC
Copy link
Contributor Author
PupoSDC commented Dec 1, 2020

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add flag for freezing the contents of the Lorem ipsum
2 participants