resolve github comments

featureform · simba-git · Apr 15, 2024 · Apr 16, 2024 · Apr 16, 2024 · Apr 16, 2024
commit 34daf9b8d29774d5e81bfd7eff2958fc81727eff
diff --git a/client/src/featureform/resources.py b/client/src/featureform/resources.py
@@ -2311,15 +2311,16 @@ def config(self):
 def _get_and_set_equivalent_variant(
     resource_variant_proto, variant_field, stub
 ) -> Optional[str]:
-    rv_proto = None
     if feature_flag.is_enabled("FF_GET_EQUIVALENT_VARIANTS", True):
-        res_pb = pb.ResourceVariant(**{variant_field: getattr(resource_variant_proto, variant_field)})
+        res_pb = pb.ResourceVariant(
+            **{variant_field: getattr(resource_variant_proto, variant_field)}
+        )
         equivalent = stub.GetEquivalent(
-                pb.ResourceVariantRequest(
-                    resource_variant=res_pb,
-                    request_id=resource_variant_proto.request_id,
-                )
+            pb.ResourceVariantRequest(
+                resource_variant=res_pb,
+                request_id=resource_variant_proto.request_id,
             )
+        )
         rv_proto = getattr(resource_variant_proto, variant_field)
 
         # grpc call returns the default ResourceVariant proto when equivalent doesn't exist which explains the below check

diff --git a/coordinator/coordinator.go b/coordinator/coordinator.go
@@ -410,7 +410,7 @@ func (c *Coordinator) verifyCompletionOfSources(sources []metadata.NameVariant)
 				totalReady += 1
 			}
 			if sourceVariant.Status() == metadata.FAILED {
-				c.Logger.Infow("Source variant failed", "sourceVariant", sourceVariant)
+				c.Logger.Errorw("Source variant failed", "sourceVariant", sourceVariant)
 				wrapped := fferr.NewResourceFailedError(sourceVariant.Name(), sourceVariant.Variant(), fferr.SOURCE_VARIANT, fmt.Errorf("required dataset is in a failed state"))
 				wrapped.AddDetail("resource_status", sourceVariant.Status().String())
 				return wrapped

diff --git a/metadata/metadata.go b/metadata/metadata.go
@@ -1989,7 +1989,7 @@ type sendFn func(proto.Message) error
 type initParentFn func(name, variant string) Resource
 
 func (serv *MetadataServer) genericCreate(ctx context.Context, res Resource, init initParentFn) (*pb.Empty, error) {
-	logger := logging.GetLoggerFromContext(ctx).WithValues(map[string]interface{}{"resource-id": res.ID()})
+	logger := logging.GetLoggerFromContext(ctx).WithResource(res.ID().Type.String(), res.ID().Name, res.ID().Variant)
 	logger.Debugw("Creating Generic Resource: ", res.ID().Name, res.ID().Variant)
 
 	id := res.ID()