[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(flutter_bloc): ensure widget is mounted before invoking listener #4237

Merged
merged 1 commit into from
Aug 27, 2024
Merged

fix(flutter_bloc): ensure widget is mounted before invoking listener #4237

merged 1 commit into from
Aug 27, 2024

Conversation

felangel
Copy link
Owner

Status

READY

Breaking Changes

NO

Description

  • fix(flutter_bloc): ensure widget is mounted before invoking listener

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@felangel felangel added bug Something isn't working pkg:flutter_bloc This issue is related to the flutter_bloc package labels Aug 27, 2024
@felangel felangel self-assigned this Aug 27, 2024
@codecov Codecov
Copy link
codecov bot commented Aug 27, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (8bbd6c4) to head (80f0f85).
Report is 15 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff            @@
##            master     #4237   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           31        31           
  Lines          802       803    +1     
=========================================
+ Hits           802       803    +1
Flag Coverage Δ
flutter_bloc 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@felangel felangel merged commit 7efd54b into master Aug 27, 2024
11 checks passed
@felangel felangel deleted the fix/bloc-listener-check-mounted branch August 27, 2024 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@felangel felangel

Labels
bug Something isn't working pkg:flutter_bloc This issue is related to the flutter_bloc package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@felangel