[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(firestore-bigquery-export) Capitalize "IMPORT" in example query #119

Merged
merged 1 commit into from
Dec 10, 2019
Merged

docs(firestore-bigquery-export) Capitalize "IMPORT" in example query #119

merged 1 commit into from
Dec 10, 2019

Conversation

evenbrenna
Copy link
Contributor

Using lowercase "import" will give zero results since the value of the operation field is capitalized in rows written by the script.

Using lowercase "import" will give zero results since the value of the `operation` field is capitalized in rows written by the script.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no Author has not signed the CLA. label Nov 20, 2019
@evenbrenna
Copy link
Contributor Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes Author has signed the CLA and removed cla: no Author has not signed the CLA. labels Nov 20, 2019
@Ehesp Ehesp changed the base branch from master to next November 20, 2019 15:09
Copy link
Member
@Ehesp Ehesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - good catch!

@Ehesp Ehesp changed the title Capitalize "IMPORT" in example query docs(firestore-bigquery-export) Capitalize "IMPORT" in example query Nov 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Author has signed the CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants