[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(firebase-bigquery-change-tracker): optimize partitioning validation logic #1923

Merged
merged 1 commit into from
Jan 24, 2024
Merged

refactor(firebase-bigquery-change-tracker): optimize partitioning validation logic #1923

merged 1 commit into from
Jan 24, 2024

Conversation

jauntybrain
Copy link
Contributor
@jauntybrain jauntybrain commented Jan 15, 2024 •
edited
Loading
  • Refactored partition validation flow
  • Removed redundant and duplicated logs
  • Added correct Promise resolution

Should fix #1368 and close PR #1461

@jauntybrain jauntybrain mentioned this pull request Jan 19, 2024
Closed
@pr-Mais pr-Mais merged commit 513d14e into next Jan 24, 2024
7 checks passed
@pr-Mais pr-Mais deleted the @invertase/refactor-partition-validation branch January 24, 2024 17:00
@alexregier alexregier mentioned this pull request Apr 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pr-Mais pr-Mais pr-Mais approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[firestore-bigquery-export] Better error logging on bigquery extension when partition is set to none
2 participants
@jauntybrain @pr-Mais