Firestore API #94
Merged
Firestore API #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oreError type; Fixed index.d.ts by exporting Firestore as any; Added unit tests for utils.getProjectId()
…f these changes can be removed once the Firestore is officially released.
…als, without a project ID.
* Upgraded to latest Firestore; Exposing FieldValue and few others via admin.firestore * Fixing Admin SDK type definitions for Firestore * Exporting all Firestore types via admin.firestore * Using lodash.assign() which only copies 'own' members and none of the inheritted members. * Declaring Firestore type in terms of admin.firestore.Firestore; More integration tests for admin.firestore namespace
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementing Firestore integration. API proposal at go/firebase-admin-firestore
Usage: