[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(auth): Better type hierarchies for Auth API #1294

Merged
merged 7 commits into from
May 27, 2021
Merged

fix(auth): Better type hierarchies for Auth API #1294

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4d09b82
fix(auth): Better type heirarchies for Auth API
hiranya911 May 24, 2021
19b2c0e
fix: Moved factorId back to the base types
hiranya911 May 25, 2021
5e9e6bf
Merged with main
hiranya911 May 25, 2021
76b1e3e
fix: Updated API report
hiranya911 May 26, 2021
0330791
fix: Fixed a grammar error in comment
hiranya911 May 26, 2021
2f1d21c
fix: Update to comment text
hiranya911 May 27, 2021
6496051
Merge branch 'master' into hkj-better-types
hiranya911 May 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: Fixed a grammar error in comment
  • Loading branch information
@hiranya911
hiranya911 committed May 26, 2021
commit 03307914edf5de9b63777719ce8e47a43e890c92
8 changes: 4 additions & 4 deletions src/auth/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -479,7 +479,7 @@ export namespace auth {

/**
* Type representing the properties of a user enrolled second factor
* for an `CreateRequest`.
* for a `CreateRequest`.
*/
export type CreateMultiFactorInfoRequest = | CreatePhoneMultiFactorInfoRequest;

Expand Down Expand Up @@ -1311,7 +1311,7 @@ export namespace auth {
export interface OAuthResponseType {
/**
* Whether ID token is returned from IdP's authorization endpoint.
*/
*/
idToken?: boolean;

/**
Expand Down Expand Up @@ -1357,7 +1357,7 @@ export namespace auth {
* The OIDC provider's client secret to enable OIDC code flow.
*/
clientSecret?: string;

/**
* The OIDC provider's response object for OAuth authorization flow.
*/
Expand Down Expand Up @@ -1456,7 +1456,7 @@ export namespace auth {
* If not provided, the existing configuration's value is not modified.
*/
clientSecret?: string;

/**
* The OIDC provider's response object for OAuth authorization flow.
*/
Expand Down