[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(storage): Add getDownloadUrl method to the Storage API #2036

Merged
merged 34 commits into from
Jun 7, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
3cc7ea6
Added getDownloadUrl to storage spec
maneesht Jan 6, 2023
f617907
Removed unnecessary var assignment
maneesht Jan 6, 2023
0188a88
Updated api
maneesht Jan 6, 2023
44cbde7
Created download tokens if not available
maneesht Apr 12, 2023
a93c8d3
Addressed comments
maneesht Apr 13, 2023
925433f
Updated to fix endpoint
maneesht Apr 13, 2023
07d3fc2
Removed file
maneesht Apr 13, 2023
55362d5
Made storage modifiable
maneesht Apr 13, 2023
5ff2ec0
Updated to stop passing endpoint info around
maneesht Apr 18, 2023
d2cd1c0
Removed only
maneesht Apr 18, 2023
8581f91
Removed it only
maneesht Apr 18, 2023
784aec4
Modified to use top-level instead of extending gcs API
maneesht May 2, 2023
2ede36b
Addressed comments
maneesht May 3, 2023
8226d52
Updated docs
maneesht May 3, 2023
bcf7118
Merge remote-tracking branch 'origin/master' into mtewani/add-downloa…
maneesht May 3, 2023
d32c44d
Updated lockfile
maneesht May 3, 2023
be58f54
Updated storage integration test
maneesht May 8, 2023
a13b3e2
Updated md
maneesht May 8, 2023
712d95c
Merge branch 'master' into mtewani/add-download-link-storage
maneesht May 8, 2023
e39c051
Addresesd comments
maneesht Jun 1, 2023
b6efb5f
Reverted package-lock changes
maneesht Jun 1, 2023
116df89
Reverted from origin
maneesht Jun 1, 2023
21e9f04
Merge remote-tracking branch 'origin/master' into mtewani/add-downloa…
maneesht Jun 1, 2023
d718edf
Replaced in with of
maneesht Jun 1, 2023
89d1176
Updated env setting
maneesht Jun 1, 2023
8bfb21d
Fixed linting errors
maneesht Jun 1, 2023
3b7e2ff
Fixed test
maneesht Jun 5, 2023
5e89622
Undid fix
maneesht Jun 5, 2023
d64713b
Made sure tests worked
maneesht Jun 6, 2023
730c6f0
Removed extra env var
maneesht Jun 7, 2023
4443bf5
Addressed comments
maneesht Jun 7, 2023
54f130e
Deleted file ref
maneesht Jun 7, 2023
66f41b5
Fixed integration tests
maneesht Jun 7, 2023
a883e1b
Merge branch 'master' into mtewani/add-download-link-storage
maneesht Jun 7, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Removed only
  • Loading branch information
maneesht committed Apr 18, 2023
commit d2cd1c0bffe5739a8b281fc23d6ba0f5585b0e60
2 changes: 1 addition & 1 deletion src/storage/cloud-extensions.ts
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ export class FirebaseStorageFile extends File {
this.endpoint = (process.env.STORAGE_EMULATOR_HOST || process.env.STORAGE_HOST_OVERRIDE || 'https://firebasestorage.googleapis.com') + '/v0';
}
/**
* Gets metadata from firebase backend instead of GCS
* Gets metadata from Firebase backend instead of GCS
* @returns {FirebaseMetadata}
*/
private getFirebaseMetadata(): Promise<FirebaseMetadata> {
Expand Down
2 changes: 1 addition & 1 deletion test/integration/storage.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ chai.use(chaiAsPromised);

const expect = chai.expect;

describe.only('admin.storage', () => {
describe('admin.storage', () => {
it('bucket() returns a handle to the default bucket', () => {
const bucket: Bucket = getStorage().bucket();
return verifyBucket(bucket, 'storage().bucket()')
Expand Down