[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(auth): Add TotpInfo field to UserRecord #2197

Merged
merged 9 commits into from
Jun 27, 2023
Merged

fix(auth): Add TotpInfo field to UserRecord #2197

merged 9 commits into from
Jun 27, 2023

Conversation

pragatimodi
Copy link
Contributor
@pragatimodi pragatimodi commented May 26, 2023 •
edited
Loading

Adding a TotpInfo field to UserRecord for Admin users to view a user's MFA configuration. TOTP enrollment for users is enabled via client SDKs only.
Testing was done by manually enrolling a user on TOTP using curl and creating a test app to get the corresponding user's UserRecord configuration
Manual testing output:

MultiFactorSettings {
  enrolledFactors: [
    TotpMultiFactorInfo {
      uid: 'bd8fa8e0-194c-443e-82e9-77b39868aed7',
      factorId: 'totp',
      displayName: 'enroll-totp-test',
      enrollmentTime: 'Wed, 31 May 2023 20:39:18 GMT',
      totpInfo: {}
    }
  ]
}

@pragatimodi pragatimodi marked this pull request as ready for review May 30, 2023 21:33
@pragatimodi pragatimodi requested a review from prameshj May 30, 2023 23:09
renkelvin
renkelvin reviewed May 30, 2023
View reviewed changes
test/unit/auth/user-record.spec.ts Show resolved Hide resolved
src/auth/user-record.ts Outdated Show resolved Hide resolved
src/auth/user-record.ts Show resolved Hide resolved
prameshj
prameshj reviewed May 31, 2023
View reviewed changes
Copy link
@prameshj prameshj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the PR description to describe the change and also include the manual testing done? Thanks!

src/auth/user-record.ts Show resolved Hide resolved
src/auth/user-record.ts Show resolved Hide resolved
@pragatimodi pragatimodi force-pushed the totp-user-record branch 2 times, most recently from fd542b0 to fa82293 Compare May 31, 2023 03:55
prameshj
prameshj reviewed May 31, 2023
View reviewed changes
package.json Outdated Show resolved Hide resolved
prameshj
prameshj approved these changes May 31, 2023
View reviewed changes
Copy link
@prameshj prameshj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you leave a snippet of the user record output in the PR description? Thanks!

Xiaoshouzi-gh
Xiaoshouzi-gh approved these changes Jun 2, 2023
View reviewed changes
Copy link
Contributor
@Xiaoshouzi-gh Xiaoshouzi-gh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/auth/user-record.ts Show resolved Hide resolved
Xiaoshouzi-gh
Xiaoshouzi-gh approved these changes Jun 2, 2023
View reviewed changes
Copy link
Contributor
@Xiaoshouzi-gh Xiaoshouzi-gh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lahirumaramba lahirumaramba changed the title Adding TotpInfo to userRecord feat(auth): Add TotpInfo field to UserRecord Jun 2, 2023
lahirumaramba
lahirumaramba approved these changes Jun 27, 2023
View reviewed changes
Copy link
Member
@lahirumaramba lahirumaramba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM!

@pragatimodi pragatimodi merged commit f182c36 into master Jun 27, 2023
5 checks passed
@pragatimodi pragatimodi deleted the totp-user-record branch June 27, 2023 18:47
kevinthecheung pushed a commit that referenced this pull request Jun 27, 2023
@pragatimodi @kevinthecheung
feat(auth): Add TotpInfo field to UserRecord (#2197)
6a9a002 
* Adding TotpInfo to userRecord

* Changing type from `any` to `unknown` for type safety.

* Addressing feedback
kevinthecheung added a commit that referenced this pull request Jun 27, 2023
@kevinthecheung @pragatimodi
Fixes to password policy validation (#2227)
64f0336 
* Fixes to password policy validation

* add test

* feat(auth): Add `TotpInfo` field to `UserRecord` (#2197)

* Adding TotpInfo to userRecord

* Changing type from `any` to `unknown` for type safety.

* Addressing feedback

---------

Co-authored-by: pragatimodi <110490169+pragatimodi@users.noreply.github.com>
@lahirumaramba lahirumaramba changed the title feat(auth): Add TotpInfo field to UserRecord fix(auth): Add TotpInfo field to UserRecord Jul 10, 2023
@lahirumaramba lahirumaramba mentioned this pull request Jul 12, 2023
Merged
lahirumaramba added a commit that referenced this pull request Jul 12, 2023
@lahirumaramba
[chore] Release 11.10.0
222607e 
Includes: 
- #2216
- #2209
- #2036
- #2197
@lahirumaramba lahirumaramba mentioned this pull request Jul 12, 2023
Merged
lahirumaramba added a commit that referenced this pull request Jul 12, 2023
@lahirumaramba
[chore] Release 11.10.0 (#2246)
d18d623 
Includes: 
- #2216
- #2209
- #2036
- #2197
@roblo1801 roblo1801 mentioned this pull request May 17, 2024
Open
@X-oss-byte X-oss-byte mentioned this pull request Jun 11, 2024
Open
@aravindvnair99 aravindvnair99 mentioned this pull request Jun 12, 2024
Open
@aravindvnair99 aravindvnair99 mentioned this pull request Jun 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lahirumaramba lahirumaramba lahirumaramba approved these changes

@renkelvin renkelvin renkelvin approved these changes

@prameshj prameshj prameshj approved these changes

@Xiaoshouzi-gh Xiaoshouzi-gh Xiaoshouzi-gh approved these changes

Assignees
No one assigned
Labels
release-note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@pragatimodi @lahirumaramba @renkelvin @prameshj @Xiaoshouzi-gh