[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: multicast messaging #36

Merged
merged 7 commits into from
Mar 26, 2019
Merged

feature: multicast messaging #36

merged 7 commits into from
Mar 26, 2019

Conversation

kentcb
Copy link
Contributor
@kentcb kentcb commented Mar 21, 2019 •
edited
Loading

Add support for multicast/send-all messaging.

@kentcb kentcb mentioned this pull request Mar 21, 2019
Closed
@kentcb kentcb force-pushed the multicastmessaging branch 2 times, most recently from a855e2b to 81a4a5e Compare March 22, 2019 00:30
@kentcb kentcb marked this pull request as ready for review March 22, 2019 00:39
@kentcb
Copy link
Contributor Author
kentcb commented Mar 22, 2019

@hiranya911 Ready for review.

@hiranya911
Copy link
Contributor

Thank you @kentcb. Love what you've done here. I will take a closer look tomorrow morning. If all goes well I think we can release this next week (this API was already proposed and approved at the same time I worked on the Node and Java implementations).

@hiranya911 hiranya911 self-assigned this Mar 22, 2019
hiranya911
hiranya911 suggested changes Mar 22, 2019
View reviewed changes
Copy link
Contributor
@hiranya911 hiranya911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @kentcb for putting this together. Really appreciate you putting in the effort to provide a PR complete with unit and integration tests. I've pointed out a few things that should be changed. I think most of them are minor nits. The areas that need most work are:

  1. Validating message list in FirebaseMessagingClient
  2. Changing how MulticastMessage is unit tested

Please let me know if you have any questions.

FirebaseAdmin/FirebaseAdmin/Messaging/BatchItemResponse.cs Outdated Show resolved Hide resolved
FirebaseAdmin/FirebaseAdmin/Messaging/BatchItemResponse.cs Outdated Show resolved Hide resolved
FirebaseAdmin/FirebaseAdmin/Messaging/BatchResponse.cs Outdated Show resolved Hide resolved
FirebaseAdmin/FirebaseAdmin/Messaging/BatchResponse.cs Outdated Show resolved Hide resolved
FirebaseAdmin/FirebaseAdmin/Messaging/BatchResponse.cs Outdated Show resolved Hide resolved
FirebaseAdmin/FirebaseAdmin/Messaging/MulticastMessage.cs Outdated Show resolved Hide resolved
FirebaseAdmin/FirebaseAdmin/Extensions.cs Outdated Show resolved Hide resolved
FirebaseAdmin/FirebaseAdmin.Tests/Messaging/MulticastMessageTest.cs Outdated Show resolved Hide resolved
FirebaseAdmin/FirebaseAdmin.Tests/Messaging/MulticastMessageTest.cs Outdated Show resolved Hide resolved
FirebaseAdmin/FirebaseAdmin.Tests/Messaging/FirebaseMessagingClientTest.cs Show resolved Hide resolved
@kentcb
Copy link
Contributor Author
kentcb commented Mar 25, 2019

@hiranya911 Thanks very much for the review. I've pushed fixes based on your comments.

hiranya911
hiranya911 suggested changes Mar 25, 2019
View reviewed changes
Copy link
Contributor
@hiranya911 hiranya911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @kentcb. I think we're almost there. Just a few more changes to make. My two big feedback points are on the public API surface:

  1. What is currently called SendResponse should be called BatchResponse.
  2. What is currently called SendItemResponse should be called SendResponse.

Sorry, if it wasn't clear from my earlier comments.

FirebaseAdmin/FirebaseAdmin/Messaging/SendResponse.cs Show resolved Hide resolved
FirebaseAdmin/FirebaseAdmin/Messaging/SendItemResponse.cs Outdated Show resolved Hide resolved
FirebaseAdmin/FirebaseAdmin/Messaging/FirebaseMessagingClient.cs Outdated Show resolved Hide resolved
FirebaseAdmin/FirebaseAdmin/Messaging/SendResponse.cs Outdated Show resolved Hide resolved
FirebaseAdmin/FirebaseAdmin/Messaging/MulticastMessage.cs Outdated Show resolved Hide resolved
FirebaseAdmin/FirebaseAdmin/Messaging/FirebaseMessagingClient.cs Outdated Show resolved Hide resolved
FirebaseAdmin/FirebaseAdmin/Messaging/FirebaseMessagingClient.cs Outdated Show resolved Hide resolved
FirebaseAdmin/FirebaseAdmin/Messaging/FirebaseMessaging.cs Outdated Show resolved Hide resolved
@kentcb
Copy link
Contributor Author
kentcb commented Mar 25, 2019

@hiranya911 Ah, my bad. OK, I've fixed that as well as the other items you pointed out.

hiranya911
hiranya911 approved these changes Mar 25, 2019
View reviewed changes
Copy link
Contributor
@hiranya911 hiranya911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM 👍

I'll try to publish a release in a couple of days.

@hiranya911 hiranya911 merged commit ae0d725 into firebase:master Mar 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiranya911 hiranya911 hiranya911 approved these changes

Assignees

@hiranya911 hiranya911

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kentcb @hiranya911