[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(fcm): Added support for sending an image URL with notifications #261

Merged
merged 12 commits into from
Sep 12, 2019
Merged

feat(fcm): Added support for sending an image URL with notifications #261

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
cba18a6
add analytics_label in FcmOptions + fix FcmOptions for WebpushFcmOptions
Jun 27, 2019
3114a78
fix comment
Jun 28, 2019
d3db96a
refactor fcm to FCM
Jul 19, 2019
d2bf2c3
add image option in notification
Jul 19, 2019
038dcbd
Merge branch 'dev' into image
Jul 19, 2019
1bf9036
fix merge issue
Jul 19, 2019
bd904a0
Merge branch 'dev' into image
Jul 27, 2019
03f6318
Merge branch 'dev' into image
Aug 1, 2019
8cfa6b2
Merge branch 'dev' into image
Aug 20, 2019
6daf272
fix ImageURL and inline error check
chemidy Sep 12, 2019
98dea2d
Merge branch 'dev' into image
chemidy Sep 12, 2019
66ecfb0
fix ImageURL and validattion
chemidy Sep 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix merge issue
  • Loading branch information
Cyrille Hemidy committed Jul 19, 2019
commit 1bf903696274d03ab3a43f46e35ea93c0d70b7b7
5 changes: 0 additions & 5 deletions messaging/messaging.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,11 +283,6 @@ type AndroidFCMOptions struct {
AnalyticsLabel string `json:"analytics_label,omitempty"`
}

// AndroidFCMOptions contains additional options for features provided by the FCM Android SDK.
type AndroidFCMOptions struct {
AnalyticsLabel string `json:"analytics_label,omitempty"`
}

// WebpushConfig contains messaging options specific to the WebPush protocol.
//
// See https://tools.ietf.org/html/rfc8030#section-5 for additional details, and supported
Expand Down