[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(appcheck): Add App Check token verification #484

Merged
merged 20 commits into from
Oct 26, 2022
Merged

feat(appcheck): Add App Check token verification #484

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
350ea01
Initial appcheck.verify implementation.
bamnet Feb 4, 2022
ce26936
Return an actual token.
bamnet Feb 4, 2022
1ec1d36
Cleanup errors, comments, and more!
bamnet Feb 4, 2022
95152c9
Initial set of app check unit tests.
bamnet Feb 6, 2022
2d8b282
Add and reorganize a few more tests.
bamnet Feb 6, 2022
556e159
Fix lint errors by adding more comments.
bamnet Feb 9, 2022
a7f816a
Fix missing go-cmp module.
bamnet Feb 9, 2022
1e355b7
Fix updated variable name.
bamnet Feb 9, 2022
ff376a1
Merge remote-tracking branch 'upstream/dev' into dev
bamnet Mar 9, 2022
d07a8fd
Merge remote-tracking branch 'upstream/dev' into dev
bamnet Mar 25, 2022
0562523
Fix go-cmp dependency.
bamnet Mar 25, 2022
2b44507
Merge remote-tracking branch 'upstream/dev' into dev
bamnet Apr 11, 2022
99d7f81
Merge remote-tracking branch 'upstream/dev' into dev
bamnet Oct 21, 2022
607af6d
Doc and formatting feedback from @ lahirumaramba.
bamnet Oct 21, 2022
05f10c6
ioutil is deprecated as of Go 1.16.
bamnet Oct 21, 2022
690adc7
Cache keys for 6 hours.
bamnet Oct 21, 2022
1ac4a71
Switch to DecodedAppCheckToken.
bamnet Oct 21, 2022
4e87e6e
Remove JWKSUrl config option.
bamnet Oct 21, 2022
6f0f304
Small doc & naming tweaks.
bamnet Oct 21, 2022
82bdca3
Tweak capitalization of verifies
bamnet Oct 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove JWKSUrl config option.
  • Loading branch information
@bamnet
bamnet committed Oct 21, 2022
commit 4e87e6e79a4d5f66e727be0deefe2b027cc7b638
4 changes: 2 additions & 2 deletions appcheck/appcheck.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ import (
)

// JWKSUrl is the URL of the JWKS used to verify App Check tokens.
const JWKSUrl = "https://firebaseappcheck.googleapis.com/v1beta/jwks"
var JWKSUrl = "https://firebaseappcheck.googleapis.com/v1beta/jwks"

const appCheckIssuer = "https://firebaseappcheck.googleapis.com/"

Expand Down Expand Up @@ -74,7 +74,7 @@ type Client struct {
// the App Check service through firebase.App.
func NewClient(ctx context.Context, conf *internal.AppCheckConfig) (*Client, error) {
// TODO: Add support for overriding the HTTP client using the App one.
jwks, err := keyfunc.Get(conf.JWKSUrl, keyfunc.Options{
jwks, err := keyfunc.Get(JWKSUrl, keyfunc.Options{
Ctx: ctx,
RefreshInterval: 6 * time.Hour,
})
Expand Down
6 changes: 3 additions & 3 deletions appcheck/appcheck_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,9 @@ func TestVerifyTokenHasValidClaims(t *testing.T) {
t.Fatalf("Error loading private key: %v", err)
}

JWKSUrl = ts.URL
conf := &internal.AppCheckConfig{
ProjectID: "project_id",
JWKSUrl: ts.URL,
}

client, err := NewClient(context.Background(), conf)
Expand Down Expand Up @@ -175,9 +175,9 @@ func TestVerifyTokenMustExist(t *testing.T) {
}
defer ts.Close()

JWKSUrl = ts.URL
conf := &internal.AppCheckConfig{
ProjectID: "project_id",
JWKSUrl: ts.URL,
}

client, err := NewClient(context.Background(), conf)
Expand Down Expand Up @@ -208,9 +208,9 @@ func TestVerifyTokenNotExpired(t *testing.T) {
t.Fatalf("Error loading private key: %v", err)
}

JWKSUrl = ts.URL
conf := &internal.AppCheckConfig{
ProjectID: "project_id",
JWKSUrl: ts.URL,
}

client, err := NewClient(context.Background(), conf)
Expand Down
1 change: 0 additions & 1 deletion firebase.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,6 @@ func (a *App) Messaging(ctx context.Context) (*messaging.Client, error) {
func (a *App) AppCheck(ctx context.Context) (*appcheck.Client, error) {
conf := &internal.AppCheckConfig{
ProjectID: a.projectID,
JWKSUrl: appcheck.JWKSUrl,
}
return appcheck.NewClient(ctx, conf)
}
Expand Down
1 change: 0 additions & 1 deletion internal/internal.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,6 @@ type MessagingConfig struct {
// AppCheckConfig represents the configuration of App Check service.
type AppCheckConfig struct {
ProjectID string
JWKSUrl string
}

// MockTokenSource is a TokenSource implementation that can be used for testing.
Expand Down