[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrating Auth API to the new Identity Toolkit endpoint #256

Merged
merged 5 commits into from
Feb 7, 2019
Merged

Migrating Auth API to the new Identity Toolkit endpoint #256

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9b2b53c
Migrating Auth API to the new Identity Toolkit endpoint
hardikns Feb 4, 2019
8a685bc
fix lint errors
hardikns Feb 4, 2019
16b7733
fixed integration tests
hardikns Feb 4, 2019
73872c1
fix to support py3 test verification
hardikns Feb 5, 2019
bf4b833
fix review comments
hardikns Feb 7, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix review comments
  • Loading branch information
@hardikns
hardikns committed Feb 7, 2019
commit bf4b83326ea87613eebf66920d9a79d702613168
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Unreleased

- [added] Migrated the `FirebaseAuth` user management API to the
- [added] Migrated the `auth` user management API to the
new Identity Toolkit endpoint.
- [fixed] Extending HTTP retries to more HTTP methods like POST and PATCH.

Expand Down
2 changes: 1 addition & 1 deletion firebase_admin/auth.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -475,7 +475,7 @@ def __init__(self, app):
if not app.project_id:
raise ValueError("""Project ID is required to access the auth service.
1. Use a service account credential, or
2. set the project ID explicitly via FirebaseOptions, or
2. set the project ID explicitly via Firebase App options, or
3. set the project ID via the GOOGLE_CLOUD_PROJECT environment variable.""")

client = _http_client.JsonHttpClient(
Expand Down
7 changes: 2 additions & 5 deletions tests/test_user_mgt.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,7 @@
from firebase_admin import _user_mgt
from tests import testutils

try:
from urllib.parse import urlsplit, parse_qsl
except ImportError:
from urlparse import urlsplit, parse_qsl
from six.moves import urllib


INVALID_STRINGS = [None, '', 0, 1, True, False, list(), tuple(), dict()]
Expand Down Expand Up @@ -633,7 +630,7 @@ def _check_rpc_calls(self, recorder, expected=None):
if expected is None:
expected = {'maxResults' : '1000'}
assert len(recorder) == 1
request = dict(parse_qsl(urlsplit(recorder[0].url).query))
request = dict(urllib.parse.parse_qsl(urllib.parse.urlsplit(recorder[0].url).query))
assert request == expected


Expand Down