[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Firestore failing to return empty results from the local cache #4207

Merged
merged 8 commits into from
Oct 26, 2022
Merged

Fix Firestore failing to return empty results from the local cache #4207

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
705bf4f
add hasCachedResults flag
milaGGL Oct 15, 2022
c812c7e
fix failing test
milaGGL Oct 17, 2022
4036f2a
Merge branch 'master' into mila/Fix-Firestore-failing-to-return-empty…
milaGGL Oct 18, 2022
abf9562
port listem_spec test from js sdk to android sdk
milaGGL Oct 19, 2022
301de89
Merge branch 'master' into mila/Fix-Firestore-failing-to-return-empty…
milaGGL Oct 24, 2022
32edd5b
add integration test for raising initial snapshot from cached empty r…
milaGGL Oct 25, 2022
b24acca
resolve comments
milaGGL Oct 25, 2022
0bd5820
update changelog
milaGGL Oct 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix failing test
  • Loading branch information
@milaGGL
milaGGL committed Oct 17, 2022
commit c812c7eff9f9f92ebbbd63011b5f98ece6f6c1ff
3 changes: 2 additions & 1 deletion firebase-firestore/ktx/src/test/java/com/google/firebase/firestore/TestUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,8 @@ public static QuerySnapshot querySnapshot(
isFromCache,
mutatedKeys,
/* didSyncStateChange= */ true,
/* excludesMetadataChanges= */ false);
/* excludesMetadataChanges= */ false,
/* hasCachedResults= */ false);
return new QuerySnapshot(query(path), viewSnapshot, FIRESTORE);
}
}