[go: nahoru, domu]

Skip to content

Commit

Permalink
Divide everything into v1, v2, and common (unexported). (#1149)
Browse files Browse the repository at this point in the history
* Divide everything into v1, v2, and common (unexported).

Did some refactoring, like putting `firebaseConfig` into common.
This means we have absolutely no dependencies on v1 in common or
v2. Some files are left at the root because they were modified
in other CLs that are outstanding and I want to linearize the
changes to minimize conflicts.

While working, I removed some legacy workarounds that should no
longer apply. For example, we no longer need to load fireaseConfig
from runtime config because all supported versions of the CLI
set the FIREBASE_CONFIG environment variable. This meant we
could remove all of setup.ts because all monkeypatches were for
outdated runtimes. Since there is no longer an environment
change between importing v1/index and a subpackage, I've gone
ahead and exported the providers for v1 to minimize customer
frustration with the v1 namespace.

* Fix dependency conflicts

* Lint fixes

* Remove __trigger (#1150)

* Remove __trigger

* Lint fixes

* Divide everything into v1, v2, and common (unexported).

Did some refactoring, like putting `firebaseConfig` into common.
This means we have absolutely no dependencies on v1 in common or
v2. Some files are left at the root because they were modified
in other CLs that are outstanding and I want to linearize the
changes to minimize conflicts.

While working, I removed some legacy workarounds that should no
longer apply. For example, we no longer need to load fireaseConfig
from runtime config because all supported versions of the CLI
set the FIREBASE_CONFIG environment variable. This meant we
could remove all of setup.ts because all monkeypatches were for
outdated runtimes. Since there is no longer an environment
change between importing v1/index and a subpackage, I've gone
ahead and exported the providers for v1 to minimize customer
frustration with the v1 namespace.

* Fix dependency conflicts

* Lint fixes

* Remove __trigger (#1150)

* Remove __trigger

* Lint fixes

* Move apps and utilities into common
  • Loading branch information
inlined committed Jun 27, 2022
1 parent bebb398 commit 7ff3abe
Show file tree
Hide file tree
Showing 68 changed files with 7,005 additions and 1,836 deletions.
4 changes: 2 additions & 2 deletions integration_test/run_tests.sh
Original file line number Diff line number Diff line change
Expand Up @@ -78,9 +78,9 @@ function deploy {
./functions/node_modules/.bin/tsc -p functions/
# Deploy functions, and security rules for database and Firestore. If the deploy fails, retry twice
if [[ "${TOKEN}" == "" ]]; then
for i in 1 2 3; do firebase deploy --project="${PROJECT_ID}" --only functions,database,firestore && break; done
for i in 1 2 3; do firebase deploy --project="${PROJECT_ID}" --only functions:integration-tests,database,firestore && break; done
else
for i in 1 2 3; do firebase deploy --project="${PROJECT_ID}" --token="${TOKEN}" --only functions,database,firestore && break; done
for i in 1 2 3; do firebase deploy --project="${PROJECT_ID}" --token="${TOKEN}" --only functions:integration-tests,database,firestore && break; done
fi
}

Expand Down
Loading

0 comments on commit 7ff3abe

Please sign in to comment.