Make storage bucket parameterizeable. Create const for bucket picker #1518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbleigh
approved these changes
Jan 31, 2024
Comment on lines
+212
to
+217
| export const BUCKET_PICKER: ResourceInput = { | ||
| resource: { | ||
| type: "storage.googleapis.com/Bucket", | ||
| }, | ||
| }; | ||
|
|
There was a problem hiding this comment.
Is the helper constant even needed given VS Code will autocomplete the enum string for the resource type?
If so, might prefer naming of SELECT_STORAGE_BUCKET over BUCKET_PICKER.
There was a problem hiding this comment.
I think it is much less cringe to type a constant rather than a complex structure that has only one possible configuration. There's precedence here with the ServerValues consts/functions in RTDB/Firestore. Switched to your preferred name though.
|
Given the additional functions added, there is no question that this now needs API council review. The review is scheduled for next week. |
This was referenced May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API spec basically said to parameterize everything so I don't know why this was overlooked. Also, I've added a const BUCKET_PICKER so customers don't have to say
{ input: { resource: { type: "storage.googleapis.com/Bucket" } } }and can instead say{ input: BUCKET_PICKER }. That const might need to go through API council review though.