Adding new TOC entries. #1122
Merged
Adding new TOC entries. #1122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rring in package-lock.json.
inlined
reviewed
May 10, 2022
docgen/content-sources/v1/toc.yaml
Outdated
| - title: functions.tasks | ||
| path: /docs/reference/functions/providers_tasks.html | ||
| section: | ||
| - title: common_providers_tasks.authdata.html |
There was a problem hiding this comment.
These titles should probably be AuthData, RateLimits, Request, RetryConfig, and TaskContext respectively. Also, for v1 we don't have Request; data + TaskContext is v1 and Request is v2.
There was a problem hiding this comment.
Yup, sorry, that's how I fixed them up in the DevSite TOC.
Will fix that and remove Request.
BTW how can I remove package-lock.json from this PR? Neither revert nor checkout worked for me. Thanks!
… into eg-docgen-v1
jhuleatt
reviewed
May 10, 2022
docgen/content-sources/v1/toc.yaml
Outdated
Comment on lines
138
to
149
| - title: 'functions.tasks' | ||
| path: /docs/reference/functions/providers_tasks.html | ||
| section: | ||
| - title: AuthData | ||
| path: /docs/reference/functions/common_providers_tasks.authdata.html | ||
| - title: RateLimits | ||
| path: /docs/reference/functions/common_providers_tasks.ratelimits.html | ||
| - title: RetryConfig | ||
| path: /docs/reference/functions/common_providers_tasks.retryconfig.html | ||
| - title: TaskContext | ||
| path: /docs/reference/functions/common_providers_tasks.taskcontext.html | ||
|
|
There was a problem hiding this comment.
Looks like TaskQueueBuilder is missing
There was a problem hiding this comment.
Should be back now, thanks!
jhuleatt
approved these changes
May 10, 2022
docgen/content-sources/v1/toc.yaml
Outdated
| @@ -124,6 +126,8 @@ toc: | |||
| path: /docs/reference/functions/providers_remoteconfig.remoteconfiguser.html | |||
| - title: 'TemplateVersion' | |||
| path: /docs/reference/functions/providers_remoteconfig.templateversion.html | |||
| - title: 'Updatebuilder' | |||
There was a problem hiding this comment.
Suggested change
| - title: 'Updatebuilder' | |
| - title: 'UpdateBuilder' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Staged and discussed internally in the known places.
Thanks!