[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MLKit update in 6.26.0 introduced symbol collisions with Firestore and FirebasePerformance #5746

Closed
paulb777 opened this issue Jun 4, 2020 · 2 comments · Fixed by #6256
Closed

MLKit update in 6.26.0 introduced symbol collisions with Firestore and FirebasePerformance #5746

paulb777 opened this issue Jun 4, 2020 · 2 comments · Fixed by #6256
Assignees
@manjanac
Labels
api: ml

Comments

@paulb777
Copy link
Member
paulb777 commented Jun 4, 2020 •
edited
Loading

MLKit updated its TensorFlowLiteC dependency to 2.2 which links in abseil symbols instead of using its CocoaPod.

Details at https://github.com/firebase/firebase-ios-sdk/runs/737463642?check_suite_focus=true#step:5:2112

The symbol collision tests disabled in #5872 should be reenabled when this is fixed.
@paulb777 paulb777 added the api: mlkit Deprecated in favor of Firebase ML. label Jun 4, 2020
@paulb777 paulb777 assigned ryanwilson and paulb777 and unassigned ryanwilson Jun 4, 2020
@paulb777 paulb777 modified the milestone: 6.27.0 - M73 Jun 10, 2020
@paulb777 paulb777 assigned ryanwilson and unassigned paulb777 Jun 10, 2020
@paulb777
Copy link
Member Author

Related internal issue at b/158197349

@paulb777 paulb777 mentioned this issue Jun 22, 2020
Merged
@morganchen12 morganchen12 added api: ml and removed api: mlkit Deprecated in favor of Firebase ML. labels Jul 17, 2020
@paulb777 paulb777 assigned manjanac and unassigned ryanwilson Jul 24, 2020
@paulb777 paulb777 added this to the 6.30.0 - M77 milestone Aug 5, 2020
@paulb777
Copy link
Member Author

Removing the milestone since it needs to close today, but this issue should now be solvable.

@paulb777 paulb777 removed this from the 6.30.0 - M77 milestone Aug 11, 2020
@manjanac manjanac mentioned this issue Aug 11, 2020
Merged
@firebase firebase locked and limited conversation to collaborators Sep 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@manjanac manjanac

Labels
api: ml
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Restore ML pods in symbol collision tests firebase/firebase-ios-sdk
4 participants
@paulb777 @ryanwilson @morganchen12 @manjanac