[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore ML pods in symbol collision tests #6256

Merged
merged 2 commits into from
Aug 12, 2020
Merged

Restore ML pods in symbol collision tests #6256

merged 2 commits into from
Aug 12, 2020

Conversation

manjanac
Copy link
Contributor

FirebaseML updated its TensorFlowLiteC dependency to 2.3 which resolves previous symbol collision issues with Firestore and FirebasePerformance. This will fix #5746.

The symbol collision tests disabled in #5872 should now be re-enabled.

@manjanac manjanac requested a review from paulb777 August 11, 2020 21:51
paulb777
paulb777 approved these changes Aug 11, 2020
View reviewed changes
Copy link
Member
@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

https://github.com/firebase/firebase-ios-sdk/runs/973275306?check_suite_focus=true#step:4:173

@manjanac manjanac merged commit 6522be0 into master Aug 12, 2020
@manjanac manjanac deleted the fix_5746 branch August 12, 2020 00:15
@firebase firebase locked and limited conversation to collaborators Sep 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paulb777 paulb777 paulb777 approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MLKit update in 6.26.0 introduced symbol collisions with Firestore and FirebasePerformance
3 participants
@manjanac @paulb777 @googlebot