[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add non-fatal firebase storage init method #6974

Closed
yura-hb opened this issue Nov 16, 2020 · 4 comments
Closed

Add non-fatal firebase storage init method #6974

yura-hb opened this issue Nov 16, 2020 · 4 comments
Assignees
@paulb777
Labels
api: storage Swift API type: feature request
Milestone
Firebase 10 - M122

Comments

@yura-hb
Copy link
yura-hb commented Nov 16, 2020 •
edited
Loading

Feature proposal

  • Firebase Component: Storage (Auth, Core, Database, Firestore, Messaging, Storage, etc)

Add more swifty initialization for the reference on the firebase storage. At the moment Firebase Storage crashes the Swift app, if you provide link with incorrect domain to - (FIRStorageReference *)referenceForURL:(NSString *)string;
@morganchen12
Copy link
Contributor

Can you describe what the desired behavior would be here if passing in an incorrect domain? Should we just return an optional instead?

@yura-hb
Copy link
Author
yura-hb commented Nov 17, 2020

@morganchen12 Hello, any behaviour with error handling is enough for this case. From my point of view, optional is enough, but you can consider for throwing a Swift error in such case.

@morganchen12 morganchen12 changed the title Add more swifty firebase storage init method Add non-fatal firebase storage init method Nov 17, 2020
@paulb777 paulb777 added this to the Firebase 10 - M122 milestone Aug 29, 2022
@paulb777
Copy link
Member

Adding for consideration for Firebase 10. At first thought, I think throwing a Swift error would be best so that the return value doesn't need to be unwrapped.

@paulb777 paulb777 self-assigned this Sep 8, 2022
@paulb777 paulb777 mentioned this issue Sep 14, 2022
Merged
@paulb777
Copy link
Member

Merged to master for the upcoming 10.0.0 release

@firebase firebase locked and limited conversation to collaborators Oct 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@paulb777 paulb777

Labels
api: storage Swift API type: feature request
Projects
None yet
Milestone
Firebase 10 - M122
Development

No branches or pull requests
4 participants
@paulb777 @morganchen12 @yura-hb @google-oss-bot