[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new throwing reference(for url:URL) API #10216

Merged
merged 4 commits into from
Sep 15, 2022
Merged

Add new throwing reference(for url:URL) API #10216

merged 4 commits into from
Sep 15, 2022

Conversation

paulb777
Copy link
Member
@paulb777 paulb777 commented Sep 14, 2022 •
edited
Loading

Fix #6974

Provide a throwing API for failures instead of fatalError. Also use a URL type for the url parameter instead of String

New API open func reference(for url: URL) throws -> StorageReference equivalent to
open func reference(forURL url: String) -> StorageReference except it throws instead of
erroring.

@paulb777 paulb777 added this to the Firebase 10 - M122 milestone Sep 15, 2022
morganchen12
morganchen12 approved these changes Sep 15, 2022
View reviewed changes
FirebaseStorage/Sources/Storage.swift Outdated Show resolved Hide resolved
@paulb777 paulb777 changed the title Add new throwing ref(forURL) API Add new throwing reference(for url:URL) API Sep 15, 2022
@paulb777
Copy link
Member Author

I'm going to merge to storage-swift-phase2 to minimize branch management. Feel free to add comments and I'll address in a subsequent PR.

@paulb777 paulb777 merged commit 898757c into storage-swift-phase2 Sep 15, 2022
@paulb777 paulb777 deleted the pb-throwing-ref branch September 15, 2022 22:04
paulb777 added a commit that referenced this pull request Sep 15, 2022
@paulb777
Address missed review comments from #10216
be408c9
paulb777 added a commit that referenced this pull request Sep 15, 2022
@paulb777
Address missed review comments from #10216
b86302d
paulb777 added a commit that referenced this pull request Sep 16, 2022
@paulb777
Address missed review comments from #10216 (#10224)
3282b4d
@paulb777 paulb777 mentioned this pull request Sep 16, 2022
Merged
paulb777 added a commit that referenced this pull request Sep 21, 2022
@paulb777
Add new throwing reference(for url:URL) API (#10216)
ec0fb21
paulb777 added a commit that referenced this pull request Sep 21, 2022
@paulb777
Address missed review comments from #10216 (#10224)
2a14d44
@firebase firebase locked and limited conversation to collaborators Oct 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@morganchen12 morganchen12 morganchen12 approved these changes

@ncooke3 ncooke3 ncooke3 approved these changes

@charlotteliang charlotteliang Awaiting requested review from charlotteliang

Assignees
No one assigned
Labels
api: storage public-api-change
Projects
None yet
Milestone
Firebase 10 - M122
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@paulb777 @morganchen12 @ncooke3 @google-oss-bot