Ipv4 ipv6 fix #6428
Ipv4 ipv6 fix #6428
Conversation
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
…into ipv4-ipv6-fix
|
@googlebot I fixed it Confirmed that the code was developed with a valid CLA. |
|
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) ℹ️ Googlers: Go here for more info. |
…sm and related methods.
…stance and also for fresh app startup
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
|
@googlebot I fixed it |
|
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) ℹ️ Googlers: Go here for more info. |
There was a problem hiding this comment.
Great, thanks for fixing this! And thanks @ncooke3 for the initial commits 😄
| @@ -92,7 +92,10 @@ - (void)_showDynamicLinkInfo:(FIRDynamicLink *)dynamicLink { | |||
| [alertVC addAction:[UIAlertAction actionWithTitle:@"Dismiss" | |||
| style:UIAlertActionStyleCancel | |||
| handler:NULL]]; | |||
| [self.window.rootViewController presentViewController:alertVC animated:YES completion:NULL]; | |||
|
|
|||
| [[UIApplication sharedApplication].keyWindow.rootViewController presentViewController:alertVC | |||
There was a problem hiding this comment.
Curious why this changed from self and if the change was related to the IPV4/6 change.
There was a problem hiding this comment.
No this is not related with the ipv4/6. While testing the changes, I've seen some issues with the test app.
-
After the fresh install, when the app launches and when we try to show the Alert dialog from the AppDelegate when we receive an FDL, the alert was failing with "First responder error: non-key window attempting reload - allowing due to manual keyboard".
-
Alert was failing when universal linking when the app is started as fresh instead of opening from background.
|
Did a round of testing on the basic functionalities based on this PR and all seems working. Will merge this PR by EOD today if I'm not seeing any issues with this change |
Recreating PR #5966
Instead of using firebasedynamiclinks-ipv4.googleapis.com and firebasedynamiclinks-ipv6.googleapis.com for doing attribution calls, we are moving towards using firebasedynamiclinks.googleapis.com.
Fixes #5032
-changed ipv4 and ipv6 attribution calls with a single direct url.
-Removed and refactored code to get rid of code to handle consolidated results from ipv4 and ipv6 result.
-Made changes to Test app to show alert dialog when universal linking when app is not in background case and also for fresh start case.