[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MacOS auth issue fix. #7050

Merged
merged 5 commits into from
Nov 30, 2020
Merged

MacOS auth issue fix. #7050

merged 5 commits into from
Nov 30, 2020

Conversation

gevorgyanvahagn
Copy link
Contributor

When trying to open SFSafariViewController the default browser opens and the safariViewControllerDidFinish(_ controller: SFSafariViewController) on MacOS
Fixes #7049.

On MacOS 11 catalyst apps when trying to open SFSafariViewController the default browser opens and the safariViewControllerDidFinish(_ controller: SFSafariViewController) delegate method calls immediately.
@google-cla google-cla bot added the cla: yes label Nov 29, 2020
@paulb777
Copy link
Member

Thanks for the PR!

See other usages of TARGET_OS_MACCATALYST in the repo for more typical usages of the Catalyst check and to fix the CI failure.

@gevorgyanvahagn
Copy link
Contributor Author

Thanks for your comment @paulb777!

I've found few usages of TARGET_OS_MACCATALYST in the project similar to the following

#if TARGET_OS_MACCATALYST
  // some code here
#elif
  // some code here
#endif

is this what you mean?

@paulb777
Copy link
Member

Yes

@google-cla
Copy link
google-cla bot commented Nov 29, 2020

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@gevorgyanvahagn
Copy link
Contributor Author

@googlebot I fixed it.

@google-cla
Copy link
google-cla bot commented Nov 29, 2020

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@vahagngevorgyanpicsart
Copy link
Contributor

@googlebot I consent.

@google-cla google-cla bot added cla: yes and removed cla: no labels Nov 29, 2020
@paulb777
Copy link
Member

Thanks @gevorgyanvahagn ! The change looks good to me and safe since it only changes code for the Catalyst community-supported distribution.

Assigning to the FirebaseAuth team for review and merge.

Copy link
Member
@rosalyntan rosalyntan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@rosalyntan rosalyntan merged commit a8dd5f1 into firebase:master Nov 30, 2020
paulb777 added a commit that referenced this pull request Dec 1, 2020
paulb777 added a commit that referenced this pull request Dec 1, 2020
manjanac pushed a commit that referenced this pull request Dec 1, 2020
* MacOS auth issue fix.

On MacOS 11 catalyst apps when trying to open SFSafariViewController the default browser opens and the safariViewControllerDidFinish(_ controller: SFSafariViewController) delegate method calls immediately.

* TARGET_OS_MACCATALYST usige style fixed.

* Fix elif macro issue.

* Fixed wrong file changes.

* Fix formatting.

Co-authored-by: Vahagn Gevorgyan <vahagn.gevorgyan@picsart.com>
paulb777 added a commit that referenced this pull request Dec 2, 2020
@firebase firebase locked and limited conversation to collaborators Dec 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrating PhoneAuth with Firebase for Mac Catalyst
4 participants