-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MacOS auth issue fix. #7050
MacOS auth issue fix. #7050
Conversation
On MacOS 11 catalyst apps when trying to open SFSafariViewController the default browser opens and the safariViewControllerDidFinish(_ controller: SFSafariViewController) delegate method calls immediately.
Thanks for the PR! See other usages of |
Thanks for your comment @paulb777! I've found few usages of
is this what you mean? |
Yes |
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
@googlebot I fixed it. |
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
@googlebot I consent. |
Thanks @gevorgyanvahagn ! The change looks good to me and safe since it only changes code for the Catalyst community-supported distribution. Assigning to the FirebaseAuth team for review and merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
* MacOS auth issue fix. On MacOS 11 catalyst apps when trying to open SFSafariViewController the default browser opens and the safariViewControllerDidFinish(_ controller: SFSafariViewController) delegate method calls immediately. * TARGET_OS_MACCATALYST usige style fixed. * Fix elif macro issue. * Fixed wrong file changes. * Fix formatting. Co-authored-by: Vahagn Gevorgyan <vahagn.gevorgyan@picsart.com>
When trying to open SFSafariViewController the default browser opens and the safariViewControllerDidFinish(_ controller: SFSafariViewController) on MacOS
Fixes #7049.