[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix startAfter/endBefore for orderByKeys queries #7403

Merged
merged 13 commits into from
Feb 10, 2021
Merged

Fix startAfter/endBefore for orderByKeys queries #7403

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
7133fa3
Fix startAfter/endBefore for orderByKeys queries
jmwski Jan 29, 2021
d5ee589
review feedback
jmwski Jan 29, 2021
aecf0c1
fix error statuses
jmwski Jan 29, 2021
0d7882a
changelog + error message wording
jmwski Feb 1, 2021
98689a9
Merge branch 'master' into jw/orderbykey-start-after
jmwski Feb 1, 2021
90e3b90
cleanup changelog
jmwski Feb 1, 2021
9691f24
fix get
jmwski Feb 3, 2021
0378605
more fixing of get()
jmwski Feb 3, 2021
ffaabb9
Add [node isEmpty] check to getData
jmwski Feb 3, 2021
92ffff6
Complete event snap
jmwski Feb 3, 2021
8dd29d3
Address review feedback
jmwski Feb 4, 2021
3fd687d
Add methods for querying the event cache of a view
jmwski Feb 5, 2021
b210963
pending writes
jmwski Feb 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Complete event snap
  • Loading branch information
@jmwski
jmwski committed Feb 3, 2021
commit 92ffff6f22add7bd5e1d691a2ec2125a7f9c01df
2 changes: 1 addition & 1 deletion FirebaseDatabase/Sources/Core/FSyncTree.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -779,7 +779,7 @@ - (FIndexedNode *)persistenceServerCache:(FQuerySpec *)querySpec {
getView:query
writesCache:[_pendingWriteTree childWritesForPath:[query path]]
serverCache:serverCache];
return [view serverCache];
return [view completeEventCache];
}
return nil;
}
Expand Down
1 change: 1 addition & 0 deletions FirebaseDatabase/Sources/Core/View/FView.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@

- (id<FNode>)eventCache;
- (id<FNode>)serverCache;
- (id<FNode>)completeEventCache;
- (id<FNode>)completeServerCacheFor:(FPath *)path;
- (BOOL)isEmpty;

Expand Down
4 changes: 4 additions & 0 deletions FirebaseDatabase/Sources/Core/View/FView.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,10 @@ - (id)initWithQuery:(FQuerySpec *)query
return self.viewCache.cachedEventSnap.node;
}

- (id<FNode>)completeEventCache {
return self.viewCache.completeEventSnap;
}

- (id<FNode>)completeServerCacheFor:(FPath *)path {
id<FNode> cache = self.viewCache.completeServerSnap;
if (cache) {
Expand Down