[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Xcode 13 beta 3 build issues #8405

Merged
merged 2 commits into from
Jul 19, 2021
Merged

Fix Xcode 13 beta 3 build issues #8405

merged 2 commits into from
Jul 19, 2021

Conversation

paulb777
Copy link
Member
@paulb777 paulb777 commented Jul 18, 2021 •
edited
Loading

@google-cla google-cla bot added the cla: yes label Jul 18, 2021
@paulb777 paulb777 mentioned this pull request Jul 18, 2021
Closed
@google-oss-bot
Copy link
google-oss-bot commented Jul 18, 2021 •
edited
Loading

Coverage Report

Affected SDKs

No changes between base commit (8e86fda) and head commit (c8f9bda).

Test Logs

@paulb777
Copy link
Member Author

Note the travis CI failure is dealt with separately in #8404

maksymmalyhin
maksymmalyhin approved these changes Jul 19, 2021
View reviewed changes
Copy link
Contributor
@maksymmalyhin maksymmalyhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you Paul

ryanwilson
ryanwilson reviewed Jul 19, 2021
View reviewed changes
Copy link
Member
@ryanwilson ryanwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, thanks for the fix. A couple questions for product owners and comment about cherry-picking to the release.

FirebaseAppCheck/Tests/Unit/Swift/AppCheckAPITests.swift Show resolved Hide resolved
FirebaseDynamicLinks/Sources/Public/FirebaseDynamicLinks/FIRDynamicLinks.h Show resolved Hide resolved
FirebaseInAppMessaging/Sources/Public/FirebaseInAppMessaging/FIRInAppMessaging.h Show resolved Hide resolved
FirebaseInAppMessaging/Swift/Source/SwiftUIPreviewHelpers.swift Show resolved Hide resolved
@paulb777
Copy link
Member Author

Merging without full CI since only CHANGELOGs changed.

@paulb777 paulb777 merged commit c0df01d into master Jul 19, 2021
@paulb777 paulb777 deleted the pb-xc-beta3 branch July 19, 2021 14:18
paulb777 added a commit that referenced this pull request Jul 19, 2021
@paulb777
Fix Xcode 13 beta 3 build issues (#8405)
82394b8
paulb777 added a commit that referenced this pull request Jul 19, 2021
@paulb777
Cherry-pick fixing Xcode 13 beta 3 build issues (#8405) (#8410)
7e08e6e
@MatejBalantic MatejBalantic mentioned this pull request Jul 26, 2021
Closed
@paulb777 paulb777 mentioned this pull request Aug 10, 2021
Closed
@firebase firebase locked and limited conversation to collaborators Aug 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ryanwilson ryanwilson ryanwilson left review comments

@maksymmalyhin maksymmalyhin maksymmalyhin approved these changes

Assignees
No one assigned
Labels
api: appcheck api: appdistribution api: dynamiclinks api: functions api: inappmessaging Firebase In App Messaging cla: yes public-api-change
Projects
None yet
Milestone
No milestone
4 participants
@paulb777 @google-oss-bot @ryanwilson @maksymmalyhin