[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test handle universal link #8793

Merged
merged 5 commits into from
Oct 13, 2021
Merged

Test handle universal link #8793

merged 5 commits into from
Oct 13, 2021

Conversation

eldhosembabu
Copy link
Contributor

Add unit test to check DynamicLinks.dynamicLinks().handleUniversalLink(url) to return YES for Links of the format https://*.page.link/test

Related Issue : #8786

@google-cla google-cla bot added the cla: yes label Oct 12, 2021
@eldhosembabu
Copy link
Contributor Author

#no-changelog

@google-oss-bot
Copy link
google-oss-bot commented Oct 12, 2021 •
edited
Loading

Coverage Report

Affected SDKs

No changes between base commit (6a12566) and head commit (e2f8ba3).

Test Logs

@eldhosembabu eldhosembabu mentioned this pull request Oct 12, 2021
Closed
@google-oss-bot
Copy link
google-oss-bot commented Oct 12, 2021 •
edited
Loading

Binary Size Report

Affected SDKs

No changes between base commit (6a12566) and head commit (e2f8ba3).

Test Logs

paulb777
paulb777 approved these changes Oct 13, 2021
View reviewed changes
Copy link
Member
@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for investigating!

paulb777
paulb777 approved these changes Oct 13, 2021
View reviewed changes
Copy link
Member
@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with Changelog updates and green CI

FirebaseDynamicLinks/CHANGELOG.md Show resolved Hide resolved
@eldhosembabu eldhosembabu merged commit 9b194b8 into master Oct 13, 2021
@eldhosembabu eldhosembabu deleted the test-handle-universal-link branch October 13, 2021 20:06
@paulb777 paulb777 mentioned this pull request Oct 21, 2021
Closed
@firebase firebase locked and limited conversation to collaborators Nov 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paulb777 paulb777 paulb777 approved these changes

Assignees
No one assigned
Labels
api: dynamiclinks cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@eldhosembabu @google-oss-bot @paulb777