fix: issue where deployment targets for subspec AppCheck in Firebase podspec does not match FirebaseAppCheck podspec
#9187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…se` podspec does not match `FirebaseAppCheck` podspec
paulb777
requested changes
Jan 10, 2022
There was a problem hiding this comment.
@Salakar Thanks for pointing this out. The fix is actually the obvious to update FirebaseAppCheck.podspec to match since AppCheck requires iOS 11 etc. Let us know if you want to continue. Otherwise, we'll make the correction before the next release.
|
Hmm, on further investigation, I'm not sure the correct setup here. https://firebase.google.com/docs/ios/learn-more#firebase_library_support_by_platform shows three different lines for AppCheck. |
paulb777
approved these changes
Jan 10, 2022
There was a problem hiding this comment.
Based on the updates in #8388, this change should have been done then as well, so it looks good. Thanks! and thanks to @ryanwilson for tracking down the provenance.
leotianlizhan
pushed a commit
that referenced
this pull request
Feb 1, 2022
…se` podspec does not match `FirebaseAppCheck` podspec (#9187)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussion
The deployment targets defined in https://github.com/firebase/firebase-ios-sdk/blob/master/FirebaseAppCheck.podspec#L20-L23 are not reflected in the
AppChecksubspec in the mainFirebasepodspec. This PR updates them to match.Testing
API Changes