[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix secure coding bugs in MFA #10633

Merged
merged 4 commits into from
Jan 4, 2023
Merged

Fix secure coding bugs in MFA #10633

merged 4 commits into from
Jan 4, 2023

Conversation

igor-makarov
Copy link
Contributor

Fixes #10632

@igor-makarov igor-makarov mentioned this pull request Jan 3, 2023
Closed
@paulb777
Copy link
Member
paulb777 commented Jan 3, 2023

Thanks @igor-makarov !

Here's a diff to fix the style CI problem:

diff --git a/FirebaseAuth/Sources/MultiFactor/FIRMultiFactor.m b/FirebaseAuth/Sources/MultiFactor/FIRMultiFactor.m
index 3ef2ad469..8cd66b9bc 100644
--- a/FirebaseAuth/Sources/MultiFactor/FIRMultiFactor.m
+++ b/FirebaseAuth/Sources/MultiFactor/FIRMultiFactor.m
@@ -178,8 +178,9 @@ static NSString *kUserCodingKey = @"user";
 - (nullable instancetype)initWithCoder:(NSCoder *)aDecoder {
   self = [self init];
   if (self) {
-    NSSet *enrolledFactorsClasses =
-        [NSSet setWithArray:@[ [NSArray class], [FIRMultiFactorInfo class], [FIRPhoneMultiFactorInfo class] ]];
+    NSSet *enrolledFactorsClasses = [NSSet setWithArray:@[
+      [NSArray class], [FIRMultiFactorInfo class], [FIRPhoneMultiFactorInfo class]
+    ]];

@renkelvin
Copy link
Contributor

Thanks @igor-makarov! Please apply the fix as @paulb777 suggests and I'll approve this PR.

@igor-makarov
Copy link
Contributor Author

@paulb777 @renkelvin I've applied the style fixes

@paulb777 paulb777 added this to the 10.4.0 - M126 milestone Jan 4, 2023
renkelvin
renkelvin approved these changes Jan 4, 2023
View reviewed changes
Copy link
Contributor
@renkelvin renkelvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@paulb777 paulb777 merged commit 1095aaf into firebase:master Jan 4, 2023
@firebase firebase locked and limited conversation to collaborators Feb 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@renkelvin renkelvin renkelvin approved these changes

Assignees

@renkelvin renkelvin

Labels
api: auth
Projects
None yet
Milestone
10.4.0 - M126
Development

Successfully merging this pull request may close these issues.

FIRMultiFactor does not support NSSecureCoding correctly
3 participants
@igor-makarov @paulb777 @renkelvin