Fix assign default on fetcherCompletion #1721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
From travis: Run scripts/style.sh and git add the result. |
paulb777
requested changes
Aug 21, 2018
paulb777
approved these changes
Aug 21, 2018
There was a problem hiding this comment.
LGTM - please wait for @schmidt-sebastian's approval before merging.
schmidt-sebastian
approved these changes
Aug 21, 2018
| if (callback) { | ||
| callback(self.error); | ||
| __strong FIRStorageDeleteTask *strongSelf = weakSelf; | ||
| if (strongSelf != nil) { |
There was a problem hiding this comment.
Nit: I don't feel strongly, but rest of the code mostly uses if(var) for nil checks.
morganchen12
added a commit
to morganchen12/firebase-ios-sdk
that referenced
this pull request
Aug 24, 2018
morganchen12
added a commit
that referenced
this pull request
Aug 24, 2018
Revert "Merge pull request #1721 from morganchen12/assign"
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1565.