[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add supporting of custom fdl domain #1810

Merged
merged 3 commits into from
Sep 14, 2018
Merged

Add supporting of custom fdl domain #1810

merged 3 commits into from
Sep 14, 2018

Conversation

renkelvin
Copy link
Contributor

Add supporting of custom fdl domain

@renkelvin renkelvin self-assigned this Sep 12, 2018
morganchen12
morganchen12 approved these changes Sep 12, 2018
View reviewed changes
Copy link
Contributor
@morganchen12 morganchen12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

paulb777
paulb777 requested changes Sep 12, 2018
View reviewed changes
Copy link
Member
@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your first PR to firebase-ios-sdk!

Firebase/Auth/Source/FIRAuthErrorUtils.m Outdated Show resolved Hide resolved
@renkelvin
Copy link
Contributor Author

Updated with a tiny change.
Please take a another look and I'm going to merge it. Thank you!

@paulb777
Copy link
Member

LGTM

@renkelvin renkelvin merged commit 5e59ba1 into master Sep 14, 2018
@renkelvin renkelvin deleted the custom-fdl-domain branch September 14, 2018 02:42
@renkelvin renkelvin restored the custom-fdl-domain branch September 14, 2018 23:19
renkelvin added a commit that referenced this pull request Sep 14, 2018
@renkelvin
Revert "Add supporting of custom fdl domain (#1810)"
ed6da44 
This reverts commit 5e59ba1.
@renkelvin renkelvin mentioned this pull request Sep 14, 2018
Merged
@renkelvin renkelvin deleted the custom-fdl-domain branch September 15, 2018 00:35
@renkelvin renkelvin restored the custom-fdl-domain branch November 26, 2018 22:43
@renkelvin renkelvin mentioned this pull request Nov 26, 2018
Merged
@renkelvin renkelvin deleted the custom-fdl-domain branch November 27, 2018 06:19
@firebase firebase locked and limited conversation to collaborators Oct 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paulb777 paulb777 paulb777 approved these changes

@morganchen12 morganchen12 morganchen12 approved these changes

@Yue-Wang-Google Yue-Wang-Google Awaiting requested review from Yue-Wang-Google

Assignees

@renkelvin renkelvin

Labels
api: auth cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@renkelvin @paulb777 @morganchen12 @googlebot