[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash in FIRInstanceID #3465

Merged
merged 1 commit into from
Jul 31, 2019
Merged

Fix crash in FIRInstanceID #3465

merged 1 commit into from
Jul 31, 2019

Conversation

morganchen12
Copy link
Contributor

Fixes #3439.

charlotteliang
charlotteliang approved these changes Jul 29, 2019
View reviewed changes
Firebase/InstanceID/FIRInstanceID.m Outdated Show resolved Hide resolved
@paulb777
Copy link
Member

Fix style and run travis

@morganchen12 morganchen12 force-pushed the morganchen/instanceid-patch branch 2 times, most recently from be1d40a to 9c2eef1 Compare July 30, 2019 17:02
@morganchen12 morganchen12 merged commit 61b904d into master Jul 31, 2019
@morganchen12 morganchen12 deleted the morganchen/instanceid-patch branch July 31, 2019 21:36
@paulb777
Copy link
Member

@morganchen12 @chliangGoogle @davidair It looks like this missed the 6.6.0 branch by 20 minutes. Should it be added?

@charlotteliang
Copy link
Contributor

I'm fine either way, @morganchen12 can you help release IID if this goes into 6.6.0?

@davidair
Copy link
Contributor

We can cherrypick this on Thursday

@morganchen12
Copy link
Contributor Author

I can help release IID. I'm also ok with waiting for the next release if cherry-picking causes significant issues.

@paulb777
Copy link
Member

I just rebased release-6.6.0 with this fix.

@paulb777 paulb777 added this to the 6.6.0 milestone Jul 31, 2019
@paulb777
Copy link
Member

@morganchen12 Please update the IID release note appropriately.

@firebase firebase locked and limited conversation to collaborators Oct 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@charlotteliang charlotteliang charlotteliang approved these changes

@paulb777 paulb777 Awaiting requested review from paulb777

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
6.6.0
Development

Successfully merging this pull request may close these issues.

FIRInstanceID notifyAPNSTokenIsSet -> NSInvalidArgumentException
5 participants
@morganchen12 @paulb777 @charlotteliang @davidair @googlebot